[pkg-wine-party] Bug#764212: Bug#764212: [wine-development] Error in bash script, fi needed at line 28

jre jre.winesim at gmail.com
Thu Oct 9 12:33:46 UTC 2014

severity 764212 grave
found 764212 1.7.28-1

Raising severity because with this bug the package is not fit for
"testing". Of course "unstable" users may happily install it and use it
after fixing.

On 10/09/2014 10:46 AM, Konstantin Demin wrote:
> Please review attached patch.

Most parts of your patch aren't related to this bug but simply use
another style (replacing spaces with tabs; using bash builtins [ ]
instead of test (I would prefer that too); omitting "&&" (bad idea)).

As already noted previously the patch for this bug is really just adding
the missing "fi" (haven't tested it, but it seems obvious).

Please search the web how to submit correct patches. Basically you
should keep them minimal and adapt to the current style of the file that
you want to patch.

If you want other things changed in wine file another bug with your
patch and describe what you did there for what purpose.


More information about the pkg-wine-party mailing list