[pkg-wine-party] Bug#764212: Fwd: Bug#764212: [wine-development] Error in bash script, fi needed at line 28

Konstantin Demin rockdrilla at gmail.com
Thu Oct 9 13:50:58 UTC 2014

2014-10-09 16:33 GMT+04:00, jre <jre.winesim at gmail.com>:
> Most parts of your patch aren't related to this bug but simply use
> another style (replacing spaces with tabs; using bash builtins [ ]
> instead of test (I would prefer that too); omitting "&&" (bad idea)).
> As already noted previously the patch for this bug is really just adding
> the missing "fi" (haven't tested it, but it seems obvious).
> Please search the web how to submit correct patches. Basically you
> should keep them minimal and adapt to the current style of the file that
> you want to patch.
> If you want other things changed in wine file another bug with your
> patch and describe what you did there for what purpose.

Adding "fi" eliminates the symptoms but not the reason.
The reason is code formatting.

Compare original version:
and rewritten version:

In my opinion, my script looks a little cleaner and clearer than the original.
Besides, I have never encountered this bug - just saw your bug report
and decided to help.

Konstantin Demin

More information about the pkg-wine-party mailing list