[Pkg-x2go-devel] Fwd: Processed: changing RFP -> ITP, change owner

[Reinhard Tartler]

On Di, Okt 04, 2011 at 20:56:54 (CEST), Mike Gabriel wrote:

> Hi Reinhard,
>
> On Di 04 Okt 2011 15:48:26 CEST Reinhard Tartler wrote:
>
>> IMO, the most important blocker is the lack of a recent upstream release
>> that contains tarballs, which we could use for packaging. Or do you want
>> to go ahead and package git snapshots?
>
> There are tarballs for quite some packages available already:
>
> http://code.x2go.org/releases/source
>
> So, basically, the answer is: yes, build from tarballs.

I took a look at packaging nxcomp, but that directory gives me a lot of
unexpected headaches.

First of all, I've noticed that thanks to Stéphane, there is already an
nxcomp 3.5 package in ubuntu. This package is identical (md5sum matches)
to what is published on the nomachine website:

30a182146479004ec63b8a1b9adccfcf  nxcomp_3.5.0-1.orig.tar.gz

However, the tarball from the URL quoted above comes with the following md5sum:

449b66a2b261e670ac4eb9c96a6cbf5c  nxcomp_3.5.0-1.tar.gz

So let's check the diffstat of the differences between the contents:

>> diff -Nur nxcomp_3.5.0-1/ nxcomp/ | diffstat
 CHANGELOG                   |    4 
 INSTALL                     |   32 
 Loop.cpp                    |    4 
 Makefile.in                 |   38 
 NXvars.h                    |    2 
 Proxy.cpp                   |   17 
 configure                   | 5923 ++++++++++++++++++++++++++++++++++++++++++++
 configure.in                |    3 
 debian/changelog            |  146 -
 debian/compat               |    1 
 debian/control              |   55 
 debian/copyright            |   59 
 debian/libxcomp-dev.install |    4 
 debian/libxcomp3.install    |    2 
 debian/rules                |    9 
 debian/source/format        |    1 
 16 files changed, 5929 insertions(+), 371 deletions(-)

Now I was curious why the CHANGELOG file is different:

>> diff -u nx*/CHANGELOG
--- nxcomp/CHANGELOG	2011-05-09 16:24:39.000000000 +0200
+++ nxcomp_3.5.0-1/CHANGELOG	2011-10-04 20:30:39.000000000 +0200
@@ -1,5 +1,9 @@
 ChangeLog:
 
+nxcomp-3.5.0-2
+
+- Fixed TR11H02398. Solved a race condition when creating channels.
+
 nxcomp-3.5.0-1
 
 - Opened the 3.5.0 branch based on nxcomp-3.4.0-7.

Aha, so maybe the tarball is just mislabeled? Let's compare it against
the 3.5.0-2 tarball as found on the nomachine website:

>> diff -Nur nxcomp_3.5.0-1/ nxcomp/ | diffstat 
 INSTALL                     |   32 
 Loop.cpp                    |    4 
 Makefile.in                 |   38 
 NXvars.h                    |    2 
 configure                   | 5923 ++++++++++++++++++++++++++++++++++++++++++++
 configure.in                |    3 
 debian/changelog            |  146 -
 debian/compat               |    1 
 debian/control              |   55 
 debian/copyright            |   59 
 debian/libxcomp-dev.install |    4 
 debian/libxcomp3.install    |    2 
 debian/rules                |    9 
 debian/source/format        |    1 
 14 files changed, 5929 insertions(+), 350 deletions(-)

Better, less deletions, but still quite different.

Mike, this is a pretty confusing mess. If you want x2go to play
"upstream" for Debian, I'm okay with that. But in that case we really
need to avoid this confusion and stop distributing tarball with same
filenames but different contents. To solve this, you could either rename
nxcomp to nxcomp-x2go or change the version number to 3.5.0-2+x2go1 or
something.

Another possibility could be to take the tarballs from nomachine, and
add the x2go patches as distro patches. This would probably make sharing
patches more attractive to the freenx or neatx guys.

So long,
Reinhard


-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4