[Pkg-x2go-devel] nx-libs.git client-only version / X2Go client-side packages

[Reinhard Tartler]

On Do, Jan 05, 2012 at 14:41:27 (CET), Mike Gabriel wrote:

> Hi Reinhard,
>
> On Do 05 Jan 2012 10:17:15 CET Reinhard Tartler wrote:
>
>> On Mi, Jan 04, 2012 at 23:06:32 (CET), Mike Gabriel wrote:
>>
>>> Hi all (esp. Reinhard),
>>>
>>> On So 01 Jan 2012 20:30:30 CET Mike Gabriel wrote:
>>>
>>>> Asking all who are interested to take a look at these packages:
>>>> http://mentors.debian.net/package/nx-libs
>>>> http://mentors.debian.net/package/x2goclient
>>>> http://mentors.debian.net/package/python-x2go
>>>> http://mentors.debian.net/package/pyhoca-cli
>>>> http://mentors.debian.net/package/pyhoca-gui
>>>
>>> has anyone had some time to take a closer look at the above packages?
>>
>> I prefer to review git branches.
>
> NX Libs:
> --------
> http://anonscm.debian.org/gitweb/?p=collab-maint/x2go/nx-libs.git;a=shortlog;h=refs/heads/client-only

Can you please arrange that the branch actually builds with the standard
git-buildpackage tool? Currently, git-buildpackage compains about files
that get removed in debian/rules' clean target, and that creating the
orig.tar.gz with pristine-tar fails.

debian/rules still contains commented-out cruft.

I've tried to build the dsc. Unfortunately, it fails to build against
libpng-dev from debian/experimental:


Get:22 http://ftp2.de.debian.org/debian/ experimental/main libpng-dev amd64 1.5.6-1 [303 kB]

[...]

g++ -c -O3 -fno-rtti -fno-exceptions -I../nx-X11/exports/include -Wmissing-declarations -fPIC -DIN_ADDR_T=in_addr_t -DVERSION=\"3.5.0\"  -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DX_DISPLAY_MISSING=1 -Wall -Wpointer-arith   Pgn.cpp
Pgn.cpp: In function 'int DecompressPng16(unsigned char*, int, unsigned int, unsigned int, unsigned char*, int)':
Pgn.cpp:417:15: error: invalid use of incomplete type 'png_info {aka struct png_info_def}'
/usr/include/png.h:698:16: error: forward declaration of 'png_info {aka struct png_info_def}'
Pgn.cpp: In function 'int DecompressPng24(unsigned char*, int, unsigned int, unsigned int, unsigned char*, int)':
Pgn.cpp:568:15: error: invalid use of incomplete type 'png_info {aka struct png_info_def}'
/usr/include/png.h:698:16: error: forward declaration of 'png_info {aka struct png_info_def}'
Pgn.cpp: In function 'int DecompressPng32(unsigned char*, int, unsigned int, unsigned int, unsigned char*, int)':
Pgn.cpp:712:15: error: invalid use of incomplete type 'png_info {aka struct png_info_def}'
/usr/include/png.h:698:16: error: forward declaration of 'png_info {aka struct png_info_def}'
make[7]: *** [Pgn.o] Error 1

Probably not a blocker right now, but will definitely become RC.


 I think debian/copyright still needs major work. Currently, it lists
only these persons as copyright holders:

   Copyright (c) 1995,1996 Brian Pane
   Copyright (c) 1996,1997 Zachary Vonler and Brian Pane
   Copyright (c) 1999 Kevin Vigor and Brian Pane
   Copyright (c) 2000,2001 Gian Filippo Pinzari and Brian Pane

The files MD5.[ch] are copyright (C) 1999, 2000, 2002 Aladdin Enterprises.

I cannot imagine that this is complete. nomachine surely doesn't own the
copyright for all of nx-libs, I suspect their copyright covers their
modifications to the Xorg sources only.  However according to the Debian
Policy Manual §2.3, "every package must be accompanied by a verbatim
copy of its copyright information and distribution license".

However, I don't think I'll have the time and energy to write a proper
copyright file for nx-libs. I'd therefore recommend asking on
debian-legal, debian-devel and maybe ftp-master (but they are hugely
overworked themselves) for assistance with finding a compromise, how to
feasibly write a proper debian/copyright file that fulfills Debian's
requirements. I'm unsure on this myself.


-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4