[Pkg-xfce-devel] Bug#735478: xfce4-weather-plugin: "assertion failed" on certain data from weather.com

[Christoph Biedl]

Package: xfce4-weather-plugin
Version: 0.7.4-4
Severity: important
Tags: patch

Dear Maintainer,

starting yesterday, xfce4-weather-plugin more or less often aborts due
to an assertion failure, resulting in a pop-up box from the panel
manager. Severity not set to even grave since this might happen for
certain locations only.

The actual message is:

| weather:ERROR:weather-parsers.c:304:parse_dayf: assertion failed: (ret->hi != NULL)

Responsible is a missing value in the data sent from weather.com:

|        <lsup>1/15/14 7:00 AM CET</lsup>
|        <day d="0" t="Wednesday" dt="Jan 15">
+        <hi></hi>
|        <low>4</low>

Dropping the assertion check from the sources however does not appear
to have negative impact, patch below.

    Christoph

-- System Information:
Debian Release: 7.3
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.10.25 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages xfce4-weather-plugin depends on:
ii  libc6               2.13-38
ii  libcairo2           1.12.2-3
ii  libgdk-pixbuf2.0-0  2.26.1-1
ii  libglib2.0-0        2.33.12+really2.32.4-5
ii  libgtk2.0-0         2.24.10-2
ii  libpango1.0-0       1.30.0-1
ii  libxfce4util4       4.8.2-1
ii  libxfcegui4-4       4.8.1-5
ii  libxml2             2.8.0+dfsg1-7+nmu2
ii  xfce4-panel         4.8.6-4

xfce4-weather-plugin recommends no packages.

xfce4-weather-plugin suggests no packages.

-- no debconf information


commit 1cd371f498e87df3ba98a3418a6512f34b5d039b
Author: Christoph Biedl <debian.axhn at manchmal.in-ulm.de>
Date:   Wed Jan 15 18:08:18 2014 +0100

    Allow empty <hi></hi> in data from weather.com

diff --git a/debian/patches/99_allow_empty_hi.patch b/debian/patches/99_allow_empty_hi.patch
new file mode 100644
index 0000000..08e4a3c
--- /dev/null
+++ b/debian/patches/99_allow_empty_hi.patch
@@ -0,0 +1,10 @@
+--- a/panel-plugin/weather-parsers.c
++++ b/panel-plugin/weather-parsers.c
+@@ -301,7 +301,6 @@
+       if (NODE_IS_TYPE (cur_node, "hi"))
+         {
+           ret->hi = DATA (cur_node);
+-          g_assert (ret->hi != NULL);
+         }
+       else if (NODE_IS_TYPE (cur_node, "low"))
+         {
diff --git a/debian/patches/series b/debian/patches/series
index 6575a21..1e7632d 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
 00_license.patch
 01_uri_change.patch
+99_allow_empty_hi.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20140115/fbf8ea2a/attachment.sig>