[Pkg-xfce-devel] Bug#735478: Bug#735478: xfce4-weather-plugin: "assertion failed" on certain data from weather.com

[Yves-Alexis Perez]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Wed, Jan 15, 2014 at 06:20:54PM +0100, Christoph Biedl wrote:
> Package: xfce4-weather-plugin
> Version: 0.7.4-4
> Severity: important
> Tags: patch
> 
> Dear Maintainer,
> 
> starting yesterday, xfce4-weather-plugin more or less often aborts due
> to an assertion failure, resulting in a pop-up box from the panel
> manager. Severity not set to even grave since this might happen for
> certain locations only.
> 
> The actual message is:
> 
> | weather:ERROR:weather-parsers.c:304:parse_dayf: assertion failed: (ret->hi != NULL)
> 
> Responsible is a missing value in the data sent from weather.com:
> 
> |        <lsup>1/15/14 7:00 AM CET</lsup>
> |        <day d="0" t="Wednesday" dt="Jan 15">
> +        <hi></hi>
> |        <low>4</low>
> 
> Dropping the assertion check from the sources however does not appear
> to have negative impact, patch below.

I don't really like this, it might have bad side effects too. But it's
unlikely to be fixed upstream considering the plugin has been rewritten
completely. I'll try to take a look and see if a stable upload can be
made.

Regards,
- -- 
Yves-Alexis Perez
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBCgAGBQJS16R7AAoJEG3bU/KmdcCl6TIIAKfGKXv9jVJj42MuCJoFI+Ex
v6qt82nM18ZB0j+cYxkBlleFq5Cj/eK8VnFjdZpk8bwxTyPHjSLGaH2YIluzpjt7
HyH5hCIC/IjHgjytaJfXtztFipzTAyCSUaXKqFAe29/v9++T3R1dq4hqSJ6mFOE2
O3QJ9hlTrFBJPRHb/flqMlmMksNm3Mxd8MP8qENCwjya/F0XB922uBA7G7Oy124r
zXyOWPe+Q3yDZygAj040dpKImU39Nocn3Iu5QxBqVGiDe3/lSfLKJvkk2ip4bggh
9/l0m5COduTRjbPkpBcS1AUf8B0vKOAHhHUTTobsOLALyBmVGm91lEjAf7ltD24=
=Z5O+
-----END PGP SIGNATURE-----