[Reportbug-maint] [reportbug] r538 - in /trunk: ./ debian/changelog reportbug.py

[Sandro Tosi]

On Sun, Jun 15, 2008 at 12:35, Ben Finney <ben+debian at benfinney.id.au> wrote:
> "Sandro Tosi" <matrixhasu at gmail.com> writes:
> It's also rather dubious to say that fixing trailing whitespace is
> "rewriting history" in the changelog.

you didn't changed only the lines before signature, but even:

>  reportbug (3.29.5) unstable; urgency=low
> @@ -484,7 +484,7 @@
>     .reportbugrc files with 'bugs.debian.org' as the smtphost, and noisily
>     overrides any 'master.debian.org' settings it sees.  (Closes: #338900)
>   * s/kernel-image/linux-image/ (Closes: #336871)
> -  * Generate a Message-ID for every message sent by reportbug.
> +  * Generate a Message-ID for every message sent by reportbug.
>     (Closes: #341325)
[8<]
>  reportbug (2.10.2) unstable; urgency=low
> @@ -1385,7 +1385,7 @@
>   * Don't declare a character set on anything we send.  This should
>     resolve all of the following...
>     (Closes: #165720, #166495, #166248, #166819)
> -    (The right thing to do is figure out what character set is used, but
> +    (The right thing to do is figure out what character set is used, but
>     I'm not writing a full-blown MUA here...)
>   * Rewrite to use MIMEMultipart instead of MIMEBase.
>     (Closes: #165856, #167222)
[8<]
>  reportbug (2.7) unstable; urgency=low
> @@ -1436,12 +1436,12 @@
>
>   * The "I thought Python 2.2 was feature-frozen" release.
>   * Back off on the email module's overaggressive quoting of ASCII
> -    characters in headers.  (Something like reportbug::encode_if_needed
> +    characters in headers.  (Something like reportbug::encode_if_needed
>     probably should migrate into the email module for everyone's sanity.)
>   * I should also back off on the overaggressive q-p encoding of message
>     bodies, but we get a lhuvely DeprecationWarning if we do that...
>   * Did I mention I thought Python 2.2 was feature-frozen?
[8<]
>  reportbug (0.43) unstable; urgency=low
>
> -  * Back out change in 0.42 that broke reportbug if you didn't have a
> +  * Back out change in 0.42 that broke reportbug if you didn't have a
>     "real name".  (Closes: #50378)
>   * Don't try to get input in find_package_for() if we don't have a TTY.
>     Instead, list matching package names.  (Closes: #50622)

Again, for only the sake of an automatic change with not real advantage.

>> Please revert this changes.
>
> How would you propose we address trailing whitespace?

In the changelog? don't change the old entries, pay attention in the
current+future entries.

> If you'd prefer they not be fixed, can you say why?

What advantage their removal bring into the package? nothing, so don't
change thinks not broken, that's my policy.

> I automatically
> remove trailing whitespace in my editor, so fixing it once means that
> we avoid accidental noise in more substantial changesets.

Trailing whitespaces are so un-harmful that's doubtful worth fixing
(in the changelog it's not).

Sandro

-- 
Sandro Tosi (aka morph, Morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi