[Reportbug-maint] Modularization work in progress

[Chris Lawrence]

On Tue, Jun 24, 2008 at 10:54 PM, Ben Finney <ben+debian at benfinney.id.au> wrote:
> "Chris Lawrence" <lawrencc at debian.org> writes:
>
>> As I've alluded to, I've been working on a modularized reportbug
>> tree for the past few weeks in a git repository. [...]
>
> Interesting timing. I've just finished my more limited-scope
> modularisation work. (I didn't see any response from you, Chris, when
> I said I was working on this. Hopefully we won't be treading too much
> on each other's toes.)
>
> The goal of moving the library code into a Python pacakge directory is
> important enough that I think we should aim to achieve it soon (before
> the Debian freeze), so I've done it as a separate, minimal-impact task
> without any other structural changes.
>
> It's in the Subversion repository as the 'reportbuglib' branch,
> <URL:svn+ssh://svn.debian.org/svn/reportbug/reportbuglib>.
>
>> I'm attaching what I've got so far, which *mostly* works, but I
>> haven't tested everything and haven't adapted the unit test
>> framework to it yet or updated README.developers
>
> I have achieved what I set out to do: all the reportbug library code
> is moved into a Python package directory named 'reportbuglib', and
> everything continues to work AFAICT.
>
>> Note that the diffs are a bit messy and reflect some changes in
>> design along the way (notably the "dreportbug" -> "reportbug"
>> renaming).
>
> I've only focused on getting a working Python package directory for
> the existing library modules. The above aspects are important
> (especially I think the name 'reportbug' is the more natural name for
> the Python package directory), but can be addressed separately from
> getting the package working at all.
>
>> The easiest way to run reportbug in-tree now seems to be:
>>
>> PYTHONPATH='.' bin/reportbug (options)
>
> I haven't moved the programs into a 'bin/' directory with my current
> changes.
>
> Please have a look at this branch. I think it's ready to merge in
> *now*, to enable some of the other benefits we're aiming for in
> future, as well as assisting packaging and testing.

I'll see if I can (by hook or crook) get my tree to rebase on top of
this branch in the next day or so; since the freeze is a bit further
off than I thought it was (allegedly mid-July), we can probably get
this all in to Debian and have breathing space for any fallout.

The layout in my git tree BTW is:

bin/{querybts,reportbug}
reportbug/*.py (with a few renamings to make things a bit more logical)


Chris