[Reproducible-commits] [dpkg] 29/61: s-s-d: Fix short-lived memory leak when parsing --chuid

Jérémy Bobbio lunar at moszumanska.debian.org
Mon Sep 21 09:56:09 UTC 2015


This is an automated email from the git hooks/post-receive script.

lunar pushed a commit to branch pu/reproducible_builds
in repository dpkg.

commit bc07306f4e975bcca1b4197a35341e928fef1c89
Author: Guillem Jover <guillem at debian.org>
Date:   Mon Sep 14 21:27:20 2015 +0200

    s-s-d: Fix short-lived memory leak when parsing --chuid
    
    Introduced in commit 3db7a6eb4fd16b4cea475009bd80be3a41ada014.
    
    Warned-by: coverity
---
 utils/start-stop-daemon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utils/start-stop-daemon.c b/utils/start-stop-daemon.c
index dc1e5f4..6d74feb 100644
--- a/utils/start-stop-daemon.c
+++ b/utils/start-stop-daemon.c
@@ -1052,7 +1052,7 @@ parse_options(int argc, char * const *argv)
 			if (optarg[changeuser_len] == ':' &&
 			    optarg[changeuser_len + 1] == '\0')
 				fatal("missing group name");
-			changegroup = xstrdup(optarg + changeuser_len + 1);
+			changegroup = optarg + changeuser_len + 1;
 			break;
 		case 'g':  /* --group <group>|<gid> */
 			changegroup = optarg;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/dpkg.git



More information about the Reproducible-commits mailing list