[Reproducible-commits] [dpkg] 03/11: Dpkg::Source::Quilt: Fix chmod() arguments order

Holger Levsen holger at layer-acht.org
Tue May 3 08:43:38 UTC 2016


This is an automated email from the git hooks/post-receive script.

holger pushed a commit to annotated tag 1.16.11
in repository dpkg.

commit 5f7cdfaf8af7c38b65e73e6d5af3a73759ff6eb1
Author: Pablo Oliveira <pablo at sifflez.org>
Date:   Wed May 29 14:37:43 2013 +0200

    Dpkg::Source::Quilt: Fix chmod() arguments order
    
    In the restore_quilt_backup_files() function, the chmod() call has the
    arguments swapped. This prevents restoring quilt patches that remove
    files.
    
    Closes: #710265
    
    Signed-off-by: Guillem Jover <guillem at debian.org>
---
 debian/changelog             | 4 ++++
 scripts/Dpkg/Source/Quilt.pm | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index 9126abc..d4a28e5 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -8,6 +8,10 @@ dpkg (1.16.11) UNRELEASED; urgency=low
     code. Thanks to Lincoln Myers <lincoln at netapp.com> for the patch.
     Closes: #708607
 
+  [ Guillem Jover ]
+  * Fix chmod() arguments order in Dpkg::Source::Quilt. Closes: #710265
+    Thanks to Pablo Oliveira <pablo at sifflez.org>.
+
  -- Guillem Jover <guillem at debian.org>  Sat, 30 Mar 2013 15:48:52 +0100
 
 dpkg (1.16.10) unstable; urgency=low
diff --git a/scripts/Dpkg/Source/Quilt.pm b/scripts/Dpkg/Source/Quilt.pm
index 5ca9fb7..c4a1bf3 100644
--- a/scripts/Dpkg/Source/Quilt.pm
+++ b/scripts/Dpkg/Source/Quilt.pm
@@ -293,7 +293,7 @@ sub restore_quilt_backup_files {
                 unless (link($_, $target)) {
                     copy($_, $target) ||
                         syserr(_g("failed to copy %s to %s"), $_, $target);
-                    chmod($target, (stat(_))[2]) ||
+                    chmod((stat(_))[2], $target) ||
                         syserr(_g("unable to change permission of `%s'"), $target);
                 }
             } else {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/dpkg.git



More information about the Reproducible-commits mailing list