[Reproducible-commits] [dpkg] 07/25: dpkg: Do not leak the filepackages_iterator in dir_is_used_by_others()

[Holger Levsen]

This is an automated email from the git hooks/post-receive script.

holger pushed a commit to annotated tag 1.16.16
in repository dpkg.

commit 7c4c359473481f15aa0e8b6d2a0113cc723964b2
Author: Guillem Jover <guillem at debian.org>
Date:   Mon Apr 28 21:54:52 2014 +0200

    dpkg: Do not leak the filepackages_iterator in dir_is_used_by_others()
    
    Cherry picked from commit b6788715227adb30ba41b5a049d1cbfb9e3ff1d7.
    
    Warned-by: coverity
---
 debian/changelog | 2 ++
 src/help.c       | 1 +
 2 files changed, 3 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 08e2fa6..7e85c2d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,8 @@ dpkg (1.16.15+nmu1) UNRELEASED; urgency=low
 
   [ Guillem Jover ]
   * Do not leak long tar names on bogus or truncated archives.
+  * Do not leak the filepackages iterator when a directory is used by other
+    packages.
 
   [ Updated scripts translations ]
   * Fix typos in German (Helge Kreutzmann)
diff --git a/src/help.c b/src/help.c
index dfcf7e8..bb9350e 100644
--- a/src/help.c
+++ b/src/help.c
@@ -251,6 +251,7 @@ dir_is_used_by_others(struct filenamenode *file, struct pkginfo *pkg)
     if (other_pkg == pkg)
       continue;
 
+    filepackages_iter_free(iter);
     debug(dbg_veryverbose, "dir_is_used_by_others yes");
     return true;
   }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/dpkg.git