[Reproducible-commits] [dpkg] 08/25: dselect: Fix memory leak in set_color()

[Holger Levsen]

This is an automated email from the git hooks/post-receive script.

holger pushed a commit to annotated tag 1.16.16
in repository dpkg.

commit 0e2963ab76e7697f99c7f160dcbe1a7a6edc3200
Author: Guillem Jover <guillem at debian.org>
Date:   Mon Apr 28 21:44:17 2014 +0200

    dselect: Fix memory leak in set_color()
    
    Cherry picked from commit 3df20bdb86cb217ee55c12c8f2277f3af787bf71.
    
    Warned-by: coverity
---
 debian/changelog | 1 +
 dselect/main.cc  | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 7e85c2d..9152e1f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,7 @@ dpkg (1.16.15+nmu1) UNRELEASED; urgency=low
   * Do not leak long tar names on bogus or truncated archives.
   * Do not leak the filepackages iterator when a directory is used by other
     packages.
+  * Do not leak color string on «dselect --color».
 
   [ Updated scripts translations ]
   * Fix typos in German (Helge Kreutzmann)
diff --git a/dselect/main.cc b/dselect/main.cc
index 6cd4503..c0f2195 100644
--- a/dselect/main.cc
+++ b/dselect/main.cc
@@ -299,6 +299,8 @@ extern "C" {
                        color[screenpart].attr= color[screenpart].attr | aval;
       }
     }
+
+    free(s);
   }
 
 } /* End of extern "C" */

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/dpkg.git