[dpkg] 33/200: t: Mark partially documented POD modules as TODO

Ximin Luo infinity0 at debian.org
Wed Apr 5 15:17:11 UTC 2017


This is an automated email from the git hooks/post-receive script.

infinity0 pushed a commit to branch master
in repository dpkg.

commit 429bd8f096e1e86c700201285018cda17d78f183
Author: Guillem Jover <guillem at debian.org>
Date:   Fri Nov 11 04:23:23 2016 +0100

    t: Mark partially documented POD modules as TODO
    
    This makes sure we will not forget to get them out of the ignore list
    once they get documented.
---
 debian/changelog |  4 ++++
 t/pod-coverage.t | 19 ++++++++++++++-----
 2 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 3ee8f15..2e82e0f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,9 @@
 dpkg (1.18.15) UNRELEASED; urgency=medium
 
+  [ Guillem Jover ]
+  * Test suite:
+    - Mark partially documented POD modules as TAP TODO.
+
   [ Updated man pages translations ]
   * German (Helge Kreutzmann).
 
diff --git a/t/pod-coverage.t b/t/pod-coverage.t
index f0afbd3..7b475e8 100644
--- a/t/pod-coverage.t
+++ b/t/pod-coverage.t
@@ -17,6 +17,7 @@ use strict;
 use warnings;
 
 use File::Find;
+use Dpkg::Util qw(any);
 
 use Test::More;
 use Test::Dpkg qw(:needs);
@@ -27,6 +28,7 @@ test_needs_srcdir_switch();
 
 sub all_pod_modules
 {
+    my @modules_todo = @_;
     my @modules;
     my $scan_perl_modules = sub {
         my $module = $File::Find::name;
@@ -41,9 +43,7 @@ sub all_pod_modules
         $module =~ s{^\Q$File::Find::topdir\E/}{};
         $module =~ s{/}{::}g;
 
-        # Do not check partially private modules.
-        return if $module eq 'Dpkg::Arch';
-        return if $module eq 'Dpkg::Source::Package';
+        return if any { $module eq $_ } @modules_todo;
 
         push @modules, $module;
     };
@@ -57,10 +57,19 @@ sub all_pod_modules
     return @modules;
 }
 
-my @modules = all_pod_modules();
+my @modules_todo = qw(Dpkg::Arch Dpkg::Source::Package);
+my @modules = all_pod_modules(@modules_todo);
 
-plan tests => scalar @modules;
+plan tests => scalar @modules + scalar @modules_todo;
 
 for my $module (@modules) {
     pod_coverage_ok($module);
 }
+
+TODO: {
+    local $TODO = 'modules partially documented';
+
+    for my $module (@modules_todo) {
+        pod_coverage_ok($module);
+    }
+}

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/dpkg.git



More information about the Reproducible-commits mailing list