[dpkg] 34/200: data: Do not enable PIE when linking static programs

[Ximin Luo]

This is an automated email from the git hooks/post-receive script.

infinity0 pushed a commit to branch master
in repository dpkg.

commit 39545fbc7444e259d039fe39bd5345a2edaf8084
Author: Guillem Jover <guillem at debian.org>
Date:   Sat Nov 12 14:59:55 2016 +0100

    data: Do not enable PIE when linking static programs
    
    It seems like at least glibc does not support statically linked PIE
    programs, and produces random junk. Disable globally for now, if
    there's a desire to enable static PIE binaries, which is known to
    work on some architectures (such as musl-based ones) we can add
    specialized specs files in the future.
    
    Closes: #843714
    Proposed-by: Szabolcs Nagy <nsz at port70.net>
---
 data/pie-link.specs | 2 +-
 debian/changelog    | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/data/pie-link.specs b/data/pie-link.specs
index 35d26e1..94c122f 100644
--- a/data/pie-link.specs
+++ b/data/pie-link.specs
@@ -1,2 +1,2 @@
 *self_spec:
-+ %{!shared:%{!r:%{!fno-PIE:%{!no-pie:-fPIE -pie}}}}
++ %{!static:%{!shared:%{!r:%{!fno-PIE:%{!no-pie:-fPIE -pie}}}}}
diff --git a/debian/changelog b/debian/changelog
index 2e82e0f..33f1ef9 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,10 @@
 dpkg (1.18.15) UNRELEASED; urgency=medium
 
   [ Guillem Jover ]
+  * Improve PIE flags support:
+    - Do not enable PIE when linking static programs. glibc-based systems
+      do not support this combination and produce very bogus output.
+      Proposed by Szabolcs Nagy <nsz at port70.net>. Closes: #843714
   * Test suite:
     - Mark partially documented POD modules as TAP TODO.
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/dpkg.git