[Apt-listbugs-commits] [apt-listbugs] 01/02: add AptListbugs::Severities configuration option

[Francesco Poli]

On Sat, 7 Sep 2013 18:50:53 +0100 Serafeim Zanikolas wrote:

> On Tue, Sep 03, 2013 at 08:28:43PM +0000, Francesco Poli wrote:
> > commit e417708b602cca25be2ded8aeb797b8f5dc908de
> > Author: Francesco Poli (wintermute) <invernomuto at paranoici.org>
> > Date:   Mon Sep 2 23:54:00 2013 +0200
> > 
> >     add AptListbugs::Severities configuration option
> [..]
> >    def parse_options
> > +    if /sev_list='(.*)'/ =~ `apt-config #{@apt_conf} shell sev_list AptListbugs::Severities`
> > +      if $1 == "all"
> > +        @severity = ["critical","grave","serious","important","normal","minor","wishlist"]
> > +      else
> > +        @severity = $1.split(',')
> 
> I would encourage you to do some kind of validation here, instead of blindly
> assume that anything in this comma-separated list is a valid severity value.

There does not seem to be any validation for the -s option, either.
And it does not seem to be an issue:

$ apt-listbugs -s foo,bar,serious list apt/0.9.11.2
Retrieving bug reports... Done
Parsing Found/Fixed information... Done
serious bugs of apt (→ 0.9.11.2) <Outstanding>
 #706641 - apt, libgd-text-perl: fails to upgrade from squeeze: Could not perform immediate configuration on 'libgd-gd2-perl'. [i386]
Summary:
 apt(1 bug)



-- 
 http://www.inventati.org/frx/frx-gpg-key-transition-2010.txt
 New GnuPG key, see the transition document!
..................................................... Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/apt-listbugs-commits/attachments/20130907/618327c3/attachment.sig>