[Dbconfig-common-devel] Tested CVS version

Andreas Tille tillea@rki.de
Thu, 20 Jan 2005 07:11:22 +0100 (CET)


On Wed, 19 Jan 2005, sean finney wrote:

> guess i didn't see that one because the file previously existed
> on my system.  thanks for pointing it out.
Sure, that's why I try to support you with more "dummy users input". ;-)

>>  2) Requires bashism in maintainer scripts
>>
>>     <pkg>: possible-bashism-in-maintainer-script postinst:7 '.
>>     /usr/share/dbconfig-common/dpkg/postinst.pgsql <pkg>'
>
> if i understand this one correctly, it's complaining about
> sourcing a library and passing arguments to it at the same time?
Yes.

> if so, i'm not a big fan of this method anyway (it kind of blurs
> the difference between sourcing and executing a shell script),
> and as soon as i'm done with the cleanup after the current changes,
> i'll probably be changing the behavoiur to be something more like
>
> . /usr/share/dbconfig-common/dpkg/postinst.psql
> dbc_go <pkg> <dpkg-args>
Fine.

> anyway, i've got most of the work done on 1.1 now, and will be
> committing that after i've had a chance to shake out all the bugs,
> bashisms, and typhos.  in the meantime, i'll commit a fix for (1)
> and (3) into cvs.
Thanks, I'll try it and continue with the input.

Kind regards

           Andreas.

-- 
http://fam-tille.de