licensecheck: fixes and improvements

[Dmitry Smirnov]

On Sun, 21 Oct 2012 10:07:50 Benjamin Drung wrote:
> > For patch 1 you can find case in #688843 (as mentioned in patch header).
> > In my email as of 12 of October I attached licensecheck.pl with embedded
> > test case for this (see line 1212).
> 
> I applied patch 1 and tested it against the attached
> modified-BSD-2-clause.py, but licensecheck still detects it as "BSD (2
> clause)". The patch seems to short for the proclaimed change.
> 

You've used the wrong sample -- it's for the license that I posted on 11 of 
October. I'm attaching it here for your convenience.

Without my patch the attached license is incorrectly detected as
"BSD (2 clause)" when it is really a BSD-3-clause.

More advanced BSD detection algorithm that I posted earlier catches such cases 
as well.

-- 
Regards,
Dmitry.
-------------- next part --------------
 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions are met:
     * Redistributions of source code must retain the above copyright
       notice, this list of conditions and the following disclaimer.
     * Redistributions in binary form must reproduce the above copyright
       notice, this list of conditions and the following disclaimer in the
       documentation and/or other materials provided with the distribution.
     * Neither the name of AbiSource Corporation B.V. nor the
       names of other contributors may be used to endorse or promote products
       derived from this software without specific prior written permission.
 THIS SOFTWARE IS PROVIDED BY ABISOURCE CORPORATION B.V. AND OTHER
 CONTRIBUTORS ''AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING,
 BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
 FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL ABISOURCE
 CORPORATION B.V OR OTHER CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
 INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA,
 OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
 LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
 NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
 EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.