Bug#687452: devscripts: fails to recognize licenses in (fixed-form) Fortran code

[Francesco Poli]

On Thu, 13 Sep 2012 01:30:25 +0200 Benjamin Drung wrote:

> Am Donnerstag, den 13.09.2012, 00:08 +0200 schrieb Francesco Poli:
[...]
> > OK, this is my attempt to fix the bug.
> > 
> > I tested a modified licensecheck on the minimal test case that I
> > provided and on a directory tree containing about 11400 files to scan.
> > It seems that It Works For Me™.
[...]
> > 
> > Take into account that my Perl knowledge is just a smattering
> > and it is rusty, too...
> 
> My Perl foo isn't that good either.
> 
> Why did you move the Fortran comment removal line up to the top of the
> block?

For consistency with the other comment about C / C++ ...

But, of course, one could accommodate both comments at the end of the
corresponding statements, as in the attached patch (intended to be
applied on top of my previous one).
You are the package maintainer, you get to choose which style you
prefer!    :-)

> 
> > So please, test my patch accurately.
> 
> It passes all licensecheck tests (in test/test_licensecheck). There
> aren't that many test for licensecheck, but the test suite will grow
> with every bug report. I adapted your test case for the test suite (file
> attached).
[...]

Good, I am glad I have contributed something to the package!


Bye.


-- 
 http://www.inventati.org/frx/frx-gpg-key-transition-2010.txt
 New GnuPG key, see the transition document!
..................................................... Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: comment_fix.patch.gz
Type: application/octet-stream
Size: 324 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20120913/d714a5d1/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20120913/d714a5d1/attachment.pgp>