[Logcheck-devel] Re: [Logcheck-commits] CVS logcheck/debian

[maks attems]

hmm you didn't test your code.


On Tue, 18 May 2004, CVS User eevans-guest wrote:

> --- /cvsroot/logcheck/logcheck/debian/logcheck.postinst	2004/05/16 21:19:56	1.11
> +++ /cvsroot/logcheck/logcheck/debian/logcheck.postinst	2004/05/18 19:52:39	1.12
  [..]
> +# Update the logcheck crontab to one of the alternate intervals
> +update_crontab()
> +{
> +    CRONTAB=/etc/cron.d/logcheck
> +    TMPCRON=`mktemp /var/tmp/logcheck-cron.XXXXXX`
> +    
> +    if [ -f $CRONTAB ] && [ "$1" == "daily" ] ; then
> +        sed -e "s/^[[:digit:]*,-/]\+[[:space:]]\+[[:digit:]*,-/]\+[[:space:]]\+[[:digit:]*,-/]\+[[:space:]]\+[[:alnum:]*,-/]\+[[:space:]]\+[[:alnum:]*,-/]\+\([[:space:]]\+.\+ \/usr\/sbin\/logcheck .\+$\)/2 0 * * *\1/g" $CRONTAB > $TMPCRON
> +	cp $TMPCRON $CRONTAB
> +	chown 644 $CRONTAB
          ^ ^ ???
below one more..

> +    fi
> +    
> +    if [ -f $CRONTAB ] && [ "$1" == "weekly" ] ; then
> +        sed -e "s/^[[:digit:]*,-/]\+[[:space:]]\+[[:digit:]*,-/]\+[[:space:]]\+[[:digit:]*,-/]\+[[:space:]]\+[[:alnum:]*,-/]\+[[:space:]]\+[[:alnum:]*,-/]\+\([[:space:]]\+.\+ \/usr\/sbin\/logcheck .\+$\)/2 0 1 * *\1/g" $CRONTAB > $TMPCRON
> +	cp $TMPCRON $CRONTAB
> +	chown 644 $CRONTAB
> +    fi
> +    rm -f $TMPCRON
> +}
> +
>  case "$1" in
>      configure)
>  	# Remove old directory's
> @@ -57,6 +77,16 @@
>            chown logcheck /var/lock/logcheck &> /dev/null || true
>  	fi
>  
> --- /cvsroot/logcheck/logcheck/debian/logcheck.templates	2004/05/07 07:24:21	1.6
> +++ /cvsroot/logcheck/logcheck/debian/logcheck.templates	2004/05/18 19:52:39	1.7

please as alfie indicated on 5. may changes to logcheck.templates,
should be discussed before, didn't see your proposal?
they are really important for translators.

> @@ -20,3 +20,13 @@
>   directories.
>   .
>   Please see /usr/share/doc/logcheck for more details.
> +
> +Template: logcheck/cron
> +Type: select
> +Choices: weekly, daily, hourly
> +Default: hourly
> +_Description: How often should logcheck run to generate reports?
> + Logcheck is invoked by cron to periodically parse your log files and 
> + generate an email report. Hourly is the default and recommended 
> + interval for this, but you may also select from one of weekly or daily
> + as well.

i'm not shure if i like the last phrase? what about:
but you may also select daily or weekly as well.

a++ maks

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/logcheck-devel/attachments/20040519/10299e8b/attachment.pgp