[Pkg-gnupg-commit] [gnupg2] 33/185: speedo: Fix a minor memleak in the installer

Daniel Kahn Gillmor dkg at fifthhorseman.net
Mon Aug 7 11:55:17 UTC 2017


This is an automated email from the git hooks/post-receive script.

dkg pushed a commit to branch experimental
in repository gnupg2.

commit 13dc75a4e7cc2959003c08940fc53c6ece7b77e4
Author: Andre Heinecke <aheinecke at intevation.de>
Date:   Wed Jun 7 15:30:14 2017 +0200

    speedo: Fix a minor memleak in the installer
    
    * build-aux/speedo/w32/g4wihelp.c (path_remove): Free path_new on
    early return.
    
    --
    It's a weird condition in a once run function in a throwaway
    process but -- yeah. It's a memleak and static analysis can
    see it.
    
    GnuPG-Bug-Id: T3197
    Signed-off-by: Andre Heinecke <aheinecke at intevation.de>
---
 build-aux/speedo/w32/g4wihelp.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/build-aux/speedo/w32/g4wihelp.c b/build-aux/speedo/w32/g4wihelp.c
index d62d036..626f3f1 100644
--- a/build-aux/speedo/w32/g4wihelp.c
+++ b/build-aux/speedo/w32/g4wihelp.c
@@ -1159,7 +1159,10 @@ path_remove (HWND hwndParent, int string_size, char *variables,
   free (path);
 
   if (! changed)
-    return;
+    {
+      free (path_new);
+      return;
+    }
 
   /* Set a key for our CLSID.  */
   RegCreateKey (root_key, env_reg, &key_handle);

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-gnupg/gnupg2.git



More information about the Pkg-gnupg-commit mailing list