[SCM] libkpeople packaging branch, upstream, created. e06cb640504852f4aa2831fd8e1596f186f6db06
Diane Trout
diane-guest at alioth.debian.org
Tue Oct 1 17:59:26 UTC 2013
The branch, upstream has been created
at e06cb640504852f4aa2831fd8e1596f186f6db06 (commit)
- Shortlog ------------------------------------------------------------
commit e06cb640504852f4aa2831fd8e1596f186f6db06
Author: Diane Trout <diane at ghic.org>
Date: Tue Sep 24 21:55:10 2013 -0700
Imported Upstream version 0.0.80
commit 0234e9a11206a766b828dde85e90625215b40415
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Sep 23 23:02:38 2013 +0000
Set version numbers and so version of libraries
commit 6da1783391594002e68d645ae767c4309f87eed1
Author: Martin Klapetek <mklapetek at kde.org>
Date: Mon Sep 23 15:50:29 2013 +0200
Use proper includes and namespace
Reviewed-by: David Edmundson
commit ef992c615605afd5b0ef504dcaccaf1a9a286c03
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Sep 23 13:40:34 2013 +0100
Make all plugins load the libkpeople catalog
commit 1a859324ab5802774a7e8b113c581f5aa0be5245
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Sep 23 13:24:19 2013 +0100
Add a KCatalogLoader to make sure i18n is loaded
commit a1f09a982bdee1bc42deba2766d682fcbfc44c2c
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Sep 23 13:15:33 2013 +0100
Update messages.sh
commit 9021b68a51753fdf16b1cd1ca9d1d2259e78d9d3
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat Sep 21 15:41:51 2013 +0100
Add Messages.sh file
commit 9b7691f9ba34ec8b5c6275ecf1e150a5ea495b3e
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri Sep 20 21:37:03 2013 +0100
Add skeleton Mainpage.dox
commit 31f1afffdf7feb8054500fe360a44840d0954b2a
Author: Daniele E. Domenichelli <ddomenichelli at kde.org>
Date: Thu Sep 19 16:50:21 2013 +0200
PersonData::groups should not return duplicated entries
Reviewed-by: Martin Klapetek <martin.klapetek at gmail.com>
BUG: 325096
commit 41aabef2e5af407c89e34f9a77aabd539d7dccfa
Author: Dan Vrátil <dvratil at redhat.com>
Date: Wed Sep 18 14:07:45 2013 +0200
Minor optimization
commit cd1a0f74631835ae6dd929fcc1024eaa8ac6c600
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sun Sep 15 01:28:54 2013 +0000
d_ptr PersonDetailsView
commit 50fa6085aab830a4c4d7c0664e659a8a85b76d95
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sun Sep 15 00:58:27 2013 +0000
Rename private header files to _p.h
commit f7bbf82df2ef9a839f18836d4c92cc85d0731149
Author: l10n daemon script <scripty at kde.org>
Date: Sat Sep 14 04:03:31 2013 +0000
SVN_SILENT made messages (.desktop file)
commit 81fd2fb7070425c5aef0a001a5ba6e989ca8b1c4
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri Sep 13 03:12:01 2013 +0000
Guard against emitting dataCahnged on an invalid index
commit f40308c21b6f2e837b062e614c4fec55bf2a69b9
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri Sep 13 03:11:14 2013 +0000
Fix formatting of API docs
commit 6691f53e0577f5eee64b84bf58a87147e94be58c
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 13 04:08:52 2013 +0200
Add documentation to the MatchesSolver class
Because it deserves to be documented.
Also add the copyright of David Edmundson, because he helped me debug the
previous commit and I forgot to mention him.
Reviewed by David Edmundson
commit 1fdd7dd9a12b744984c43e47fd86fa3d3c55b824
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 13 03:56:08 2013 +0200
Fix the matchers resolver in MatchesSolver job
Properly figure out how do we want to merge the contacts.
Not closing the bug since the GUI needs a similar fix. The important part
is fix fixed now, so we won't mess with the database.
CCBUG: 324814
commit 94632482f3d162ae1ff723b291a8b88270d90864
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu Sep 12 15:47:07 2013 +0000
Add comment clarifying code
commit 6ef80139f71f0f6ac028aef0b7fb94a9f1b8ac80
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu Sep 12 15:26:34 2013 +0000
Do not call QAbstractItemModel methods from within QStandardItemModel
Otherwise we get leaks and crashes
commit 95a19b966f8e255f98d9b830c88b0f28479af1c3
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Wed Sep 11 21:51:15 2013 +0100
Document MatchesResolver so it's readable
commit 5745cc6473ea45262509a5b86d023c9066e39bf5
Author: Aleix Pol <aleixpol at kde.org>
Date: Sun Sep 8 03:55:30 2013 +0200
Improve Merge Dialog interface
Ports the dialog to use a KPixmapSequenceWidget that will be displayed when
items are being merged. The dialog doesn't close until it's done.
To do so, we use the MatchesSolver instead of calling the matching from
within the dialog and disregarding the evolution.
Less code, more features.
CCMAIL: franck.arrecot at gmail.com
commit f9d6a2a168187949de7d416a50eb9041432965e8
Author: Aleix Pol <aleixpol at kde.org>
Date: Sun Sep 8 03:52:44 2013 +0200
Small fix and cleanup
Remove unused code
properly use QSet::remove()
commit 5f6b002dd5d8e687a177b09ef8a255c2d923613e
Author: Aleix Pol <aleixpol at kde.org>
Date: Sun Sep 8 01:06:25 2013 +0200
Return the eventloop result from main
I wonder why g++ lets these things pass...
commit 179ff16a81c0d60fb94134737e6c7ee54491991b
Author: Aleix Pol <aleixpol at kde.org>
Date: Sun Sep 8 01:05:51 2013 +0200
Cosmetic changes
commit e5690d2791ffa2b761a73ad7e32ed95e46e85962
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri Sep 6 00:35:37 2013 +0000
Install abstractpersondetailswidget header file
commit 3c2c01150e8b24d2e8198301b0ce5f9001c09971
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri Sep 6 00:35:17 2013 +0000
avoid qt lower case macro names
commit e34be332dfbef8cd796de60bb631885394e80374
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Sep 5 04:21:45 2013 +0200
Don't run two jobs in parallel that have related information
We can get to race conditions regarding data being destroyed and then used,
in this case a person to which we're merging persons and contacts into a
person, in parallel.
Reviewed by David Edmundson
CCMAIL: franck.arrecot at gmail.com
commit 05a5b9b4051b3c2da12f6517e01a6345ee89eee3
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Sep 5 04:06:45 2013 +0200
Simplify fake person creation
commit 370bc4629e35b171dd348a16f51e50ceb4e5dc13
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu Sep 5 02:55:00 2013 +0000
emit dataChanged() on person item when adding/removing rows
BUG: 324361
REVIEWED-BY: Aleix Pol
commit da6059fa733928e8b36100d2a5eec11a89466064
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu Sep 5 02:40:34 2013 +0000
Fix detection of fakepeople model items
Reviewed-by: Aleix Pol
commit 89aac8743f5d45ffb54619b3b58c375fb619b3b5
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Sep 5 03:06:32 2013 +0200
Simplify the process of moving contacts around
Adds all the items in 1 go, instead of appending all of them separately.
REVIEW: 112473
commit 2ce79ee7f4e0adfb61e9275e417dbad6ec72e5e5
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Sep 3 03:30:29 2013 +0200
Prefer QHash::value to QHash::operator[]
This way we don't create null elements when the items are not found. It
will help at keeping the hashes clean and small.
Reviewed by David Edmundson
commit 78f45bd74fd7543bdf88846b5d60176e3b102678
Author: Sven Brauch <svenbrauch at googlemail.com>
Date: Mon Sep 2 15:24:25 2013 +0200
fix include paths in widgets/
commit e97206732ca2df081870b85b3b80eb4f0394b1c0
Author: Sven Brauch <svenbrauch at googlemail.com>
Date: Mon Sep 2 00:06:48 2013 +0200
Fix include paths, for real now
1) in FindKPeople.cmake, do not define $install_path/include/kpeople as
the include path, but $install_path/include, because packages using this
does #include <KPeople/Foo> already
2) fix the <KPeople/Foo>-style includes to use paths which actually work
3) do not use the <KPeople/Foo>-style includes inside the library itself
commit b2a056b7e0c7617ce4e0a6d35b8916a8f30da6da
Author: Sven Brauch <svenbrauch at googlemail.com>
Date: Sun Sep 1 21:47:13 2013 +0200
fix include directories in FindKPeople.cmake
commit b02ea28c5048dc19e4cdca66d94c11448efc6842
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat Aug 31 03:55:11 2013 +0000
Restore IM statuses being loaded
commit 4a7836d72926e3cf067558cab0db3dfb08cdb3d9
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Thu Aug 29 17:17:44 2013 +0200
Little correction in the merge function
Take First was removing it from the list, we want to keep it for
the second merge, in order to get the new person merged with the rest.
Thanks Aleix :p
commit bdc40585a1bed86e057c94ff87b2d5371a9de11c
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Thu Aug 29 11:42:25 2013 +0200
Implementation of the merge between Persons and contacts
If we're asked to create a person from several other one and
some contacts we now can, using a two way merging :
adding property of the contacts to one person and
merging this person with the rest.
Reviewed by David Ed. & Martin K.
commit 64570995dcf248a8f7f5fb4d2d6c231e6c86787d
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Wed Aug 28 19:29:44 2013 +0200
Scale the MergeContactWidget avatar to the font of the name
Reviewed with Aleix Pol
commit 66cbbedcc1091271ddeb8fc629de954da63fb4d1
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Wed Aug 28 17:27:53 2013 +0200
Fix the merge asked by MergeDialog to the model
The Url wasn't well retrieved for contact.
Tested on the UI by myself.
commit 9a5e56249ae63ef9d685426efa6db47c78018eb0
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Mon Aug 26 17:19:20 2013 +0200
Improve the merge call of mergedialog & mergecontactwidget
Simplify the code to call createPersonFromUris.
commit 7ba0612577621ab5c1bd70f1b725930a490dea08
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Mon Aug 26 16:11:10 2013 +0200
Fix the avatar trouble in the mergeContactWidget
Display well the icon of each contact suggest for the merge.
commit 129f142130c491244109565a00e38501a3a3b32f
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Tue Aug 27 23:28:03 2013 +0000
Fix nickname and contact roles being used at a display role
REVIEWED-BY: Martin Klapetek
commit 1563ab8f6a44f3c80c82d821194b55e18830801e
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Tue Aug 27 19:27:42 2013 +0000
Fix cardinality of roles returned from ContactItem to match PersonsModel documentation
commit 567a3aa8ce6f1650fb38416b403c6b58d34016d1
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Mon Aug 26 15:59:47 2013 +0200
Improve the merge Dialog UI
Set up the color for the vertical line in the QPalette.
commit 616ab27403a63348ea5b223498676e94197e9c86
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Mon Aug 26 15:57:33 2013 +0200
Fix the Merge Delegate UI
Fix: Now really display the avatar inside the merge dialog.
Simplify the code that handles avatar fetching while at it.
Reviewed with Aleix Pol
commit 45ef265873f5962157a939449cf6cff580e41869
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Mon Jul 29 16:59:26 2013 +0200
Clean unused variables compiling warnings in plugins
commit e02fdb66c2080a467e0adf629ac2f71df9d6e3b7
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Fri Jul 26 12:34:40 2013 +0200
Little Improvment of the merge Dialog UI
commit 15390b8aa1fb25c8db019b8dc3ba1c7205c4eeee
Author: l10n daemon script <scripty at kde.org>
Date: Fri Aug 2 04:26:46 2013 +0000
SVN_SILENT made messages (.desktop file)
commit d51c5683d7d47d79629c4293f37aa8316905f6cd
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jul 31 00:25:07 2013 +0200
Qt::DisplayRole must return single QVariant for roles that store lists
Contact can have more than one email or phone number so we need to
always return just one in Qt::DisplayRole.
Reviewed-by: David Edmundson
commit 62eefbb45fe7ca7386626499508870a97c69f6bf
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jul 31 00:21:11 2013 +0200
Add comments to data storing methods in ContactItem
Reviewed-by: David Edmundson
commit 04cc674b67f8d2f1d93d6dbab70a74c452a5ad96
Merge: 3c9fd46 c6d1a1e
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sun Jul 28 14:38:53 2013 +0100
Merge branch 'move_nickname_fetching'
REVIEW: 111659
commit c6d1a1e5407bd5de43eeba24e85b26f77505678e
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Tue Jul 23 16:17:12 2013 +0100
Add convenience methods for instantiating model features
commit 0fba4dd873c4f2ab6a37994187cbcc62b49605db
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Tue Jul 23 16:09:26 2013 +0100
Replace use of nco:imNickName with nco:nickname
This allows for populating the nickname role of the model without
needing to fetch all IM data.
KTp-nepomuk-feeder now populates the nco:nickname as well as the imNickName
on the contact-medium. Plus potentially other sources will populate nco:nickname
on the Contact item.
commit 3c9fd46084c82b6ed093fd5af8f65bbfccc400ff
Author: Raymond Wooninck <tittiatcoke at gmail.com>
Date: Fri Jul 26 20:31:03 2013 +0200
Temporary fix for building libkpeople from scratch.
Proper fix will be done by David Edmundson
CC: david at davidedmundson.co.uk
commit c021b0c42f7f98699e49175e852d4f7db92f559c
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Wed Jul 24 12:31:09 2013 +0200
Clean-up the duplicates tests
commit 4ac92289fb8f17cbfeb91ab9519b9b3efb1aea03
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Mon Jul 22 12:24:11 2013 +0200
Added autotest for general duplicates search
The autotest creates one contact and a contactBIS with the
same email, and launch the general search for duplicates.
Test the model, test the URI from the retrieved persons.
Plus, little fix for the specific Search autotest.
commit 22718c63c64516fedf7c010c8d109d7873ee605b
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Tue Jul 23 14:07:33 2013 +0000
Add a dialog wrapping PersonDetailsView
commit 3a715679954f87d6b870dc6cc66c38e51e2dcf3a
Author: Sven Brauch <svenbrauch at googlemail.com>
Date: Sun Jul 21 00:58:29 2013 +0200
Fix installation with custom prefixes
${KDE4_DATA_INSTALL_DIR} uses the static kde4 prefix,
so ${DATA_INSTALL_DIR} should be used instead in this case.
commit fd78b815d9e08a66d3d1feed7a149312ec31d28b
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Jul 18 18:30:28 2013 +0200
Load person for loadContact(..) if it exists
Reviewed-by: Vishesh Handa
commit f175edfeb92c603f95c5e0248aecb0a0b8e783a0
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Jul 18 16:32:46 2013 +0200
Chain if(role...) {} else if(role...)
It makes sense, because they are mutually exclusive
commit 02992cfd1fc2cbc6409e2b386e2f11ca372b5096
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Jul 18 16:19:41 2013 +0200
Separate the data fetching and the merge job spawning
This way we make sure that we're not having nepomuk changing things in
between.
Prevents some crashes.
commit 78514c1b3a0bf5458bda5f7e1fce250869b836f6
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Jul 18 16:13:38 2013 +0200
Simplify some code in the children resolution
Cache the rows value, so that it's not fetched on every iteration.
Check for the item value first, assert in case it's not available.
commit 82764b8b6c62f5a929190b4cf9b9609b4499af71
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Jul 18 16:11:10 2013 +0200
Make it possible to merge people without contacts
It's definitely needed, although there are still some cases we're not
following.
commit 7ea054df97cf7f2b3d9dabb01fcad28945a46fdb
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Jul 18 16:07:54 2013 +0200
Make sure we don't try to merge things without enough information
Will help to better identify corner cases
commit 4ea9e59b7588eae78a2f291e4748c7e6456d0347
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Jul 18 16:07:02 2013 +0200
Prevent crash when asking for the URI of a fake person without contacts
We shouldn't need this, but crashing is awkward.
Reviewed by Martin Klapetek
commit 8e82679f4a5b230bc1d5563af9d9503242219a14
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Jul 18 16:02:15 2013 +0200
remove redundant parenthesis
commit 889e0cc18e2620e304b330f195b9e5b6a5685a48
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Jul 18 16:01:52 2013 +0200
coding style change
commit c068cbd6d1f082651005a67a7e0b2ad0c178c8b1
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Jul 18 16:01:36 2013 +0200
Unknown contact string should be translatable
Reviewed by Martin Klapetek
commit cb07c241bf5d38cebc62281dc9e181d5f6a1ac5e
Author: Montel Laurent <montel at kde.org>
Date: Mon Jul 15 13:33:12 2013 +0200
Fix forward declaration
commit 1a7035949b72c015619f45675f30c25a0aae1fd7
Author: Montel Laurent <montel at kde.org>
Date: Mon Jul 15 13:32:39 2013 +0200
Fix memory leak
commit 8984f49ab7b057096d5b77c24b220e25c1b989fe
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jul 15 11:56:35 2013 +0200
Guard against null pointer
m_person is always null when the setPerson() is called for the first
time
Reviewed-by: David Edmundson
commit 65b9c9a44577d3a441863a332dcba2c37f5f59d2
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sun Jul 14 13:48:09 2013 +0000
Change bool on PersonsModelFeature to an enum
Replace the boolean parameter on PersonsModelFeature to decide
whether a feature is optional or mandatory and replace with
equivalent enum
REVIEW: 111502
commit 9fa240afda5fe2458161f932d2acf638431665f8
Author: l10n daemon script <scripty at kde.org>
Date: Sun Jul 14 04:19:54 2013 +0000
SVN_SILENT made messages (.desktop file)
commit c2c3e53ae2a02d3fd854ce68c00bfc872e0ed95d
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Tue Jul 9 12:11:09 2013 +0200
Add a new autotest for the Duplicates research
Add an autotest that creates two persons with a common contact,
check whether they are found as duplicates by our new "DoSpecificSearch" algorithm.
REVIEW: 111444
commit b699340b1dced5cc6ad428c231576c28587bcac8
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Mon Jul 8 16:49:49 2013 +0200
Those tests are not good
They are not properly testing KPeople and were not even working (somebody
stopped even building them in the past). At the moment they are just noise.
Commit comment written and patch reviewed by Aleix Pol
commit 8389fa5b4e0c28d1b905539e490e7be8f765aaa0
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Mon Jul 8 16:44:53 2013 +0200
Fix the merge contact search for one specific person.
Compare our person by URI instead of the index which is not reliable.
Reviewed with Aleix Pol
commit 69186b8abff410c78ba2191cde63c7ee76bc4411
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Thu Jul 4 17:14:38 2013 +0200
Change the text from the button, easier to understand.
commit edf1c30af372361a982d3113e774f9fba9e643be
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Thu Jul 4 17:05:32 2013 +0200
MergeWidget code adpation to the new specific search form DuplicatesFinder
Now mergeWidget setup the URI of the specific person before launching the
duplicatesFinder research : give directly the results instead of getting
all of them to filter them afterward.
Review by Aleix Pol
commit fcc3676cec858c41218fb77b397aac618af55970
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Thu Jul 4 13:45:47 2013 +0200
Fix the duplicates search for one person
The test was based on the QModelIndex which is not reliable,
now base on the URI which is unique and reliable.
commit 053269c0740310200cce23cb8771650a672738ca
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Jul 8 10:58:53 2013 +0100
Fix all licenses to be LGPL
commit 604cccd303cb85f579d30cf6fe8da8d2d83b5785
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jul 8 11:54:11 2013 +0200
Fix coding style
commit fe1f5b79740c8fa76ddc33b58842c33e92a85448
Author: l10n daemon script <scripty at kde.org>
Date: Mon Jul 8 04:06:44 2013 +0000
SVN_SILENT made messages (.desktop file)
commit 0344ceeebc4c67874761f1d960c05ec3eca25b28
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri Jul 5 15:56:32 2013 +0100
Fix crash which can result in invalid presencePlugin
BUG: 321998
commit 4c243fe0bb811c31060012e6ca157fbdd8b4d9c0
Author: l10n daemon script <scripty at kde.org>
Date: Fri Jul 5 03:50:13 2013 +0000
SVN_SILENT made messages (.desktop file)
commit 8b14e0d06c7376980d8d4924f0aad9485a156834
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Jul 4 17:41:18 2013 +0200
Fix conditional in the duplicates finder
er... yeah
commit 35084a78d7ff124c803abd7876c3de0f99eed7d7
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Jul 4 16:10:19 2013 +0200
Improve DuplicatesFinder for the MergeContactWidget
Makes DuplicatesFinder capable to only fetch the duplicates for a given
contact. It makes it a bit faster and lets us save some iterations that
would be wasted otherwise.
Reviewed by Franck Arrecot
commit c1f1c3185c75238afd5180d8ac37f7e3e0e24a24
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Thu Jul 4 13:05:29 2013 +0200
Change the way to clean the content displayed for the merge widget
Avoid logic if there is nothing to fill
commit 6321dfadc501bff3fe1e84ebd3bed0d7d26d76f9
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Thu Jul 4 12:55:19 2013 +0200
Licence changed from GPL to LGP
commit a58874ac4f773051c6b193295d80954fa0327189
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Thu Jul 4 12:21:53 2013 +0200
Setup the three previous widgets as plugins : Email, Phone and Merge
PersonDetailsView is now loading plugins with the type: AbstractPersonDetailsWidget.
Each one has a weight property to order them when displayed (future review).
This patch also changes the AbstractDetailsView to use QIcon instead of KIcon.
This is useful because it lets us strip the KDEUI dependency and KIcon wasn't being
that used anyway.
REVIEW ID : 111378
commit 27e98c1d166921172ddcdb9c77fca96c9fb33904
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Jul 4 12:42:49 2013 +0200
Make contacts merging/unmerging methods static
The reason being that not always the client application has access to
the instantiated PersonsModel as it might be hidden behind proxies and
only the proxy can be passed to the view/client app. For these cases,
it's very convenient to have these methods as static members, so we can
call it from wherever it's needed.
I've also made the createPersonFromUris return a KJob, which can be
tracked on the client side, it's also needed to obtain the new person's
uri and set the view to that uri.
REVIEW: 111386
commit 74ba3ee3a83215de16ae49e71c167f29b69c1a11
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Jul 4 00:23:16 2013 +0200
Emit dataChanged() for persons too when contact gets updated
Fixes few bugs like dynamic sorting by presence in contact list
Reviewed-by: David Edmundson
commit f02298abe8c4dfe109992fb9786d271d35d1c3b1
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Jul 4 00:06:21 2013 +0200
Use KDE4_BUILD_TESTS for toggling tests building
This variable name is standard across all KDE
commit 8a785911708d5ea3e2f0257206127988e2632ce2
Author: Johannes Huber <johu at gentoo.org>
Date: Wed Jul 3 22:33:09 2013 +0200
Add build options for tests and examples
Reviewed-by: Martin Klapetek
commit 96fbf4c558afb4a2a0f398e1c8af08ab525d65a3
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jul 3 19:17:55 2013 +0200
Add LGPLv2.1 license file
commit 530ceeccb7b2b5ee18e425447a263e443c8c947b
Author: l10n daemon script <scripty at kde.org>
Date: Wed Jul 3 04:02:36 2013 +0000
SVN_SILENT made messages (.desktop file)
commit 2699793c0d37d3c508fa47f1c075de3794c90ed7
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jul 3 00:57:36 2013 +0200
Return only imIDs in imAccounts
Any other information can be obtained from KTp plugin using just the id.
Reviewed-by: David Edmundson
commit c50b54e8de7cca45bbd61f8da9d3135e28471d14
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Jul 2 15:52:34 2013 +0200
Don't use kpeople/ in includes
Otherwise we're referring exclusively to the ones installed and
things go wrong
Reviewed by David
commit c349f6379d181a0a101b9efe32bc9498adbda4a0
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jul 1 23:07:54 2013 +0200
Fix compiler warnings
commit 80be63b41cc92edb09d4d47a83d01d9b7c378280
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jul 1 22:49:20 2013 +0200
Fix ALL the coding style
Or most of it. Plus:
* Clean license headers
* Clean include headers
* Remove unused include headers(!!!)
* Normalise signals/slots signatures
* Unify foreach vs Q_FOREACH; use Q_FOREACH
commit e82636a7be7df14884f5c3fa0360090cf073f0b6
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jul 1 21:47:31 2013 +0200
Fix header include
Fixes PersonViewer build
Reviewed-by: David Edmundson
commit dd347075e475c6a8e0d986ca92965f70417a16d2
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Jul 1 19:45:24 2013 +0100
Fix header include
commit ed805aeb6b9d0d7f5e6eece0b097d942eb4e53b3
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Jul 1 18:58:59 2013 +0100
Make PersonData::uri() method always return the real URI i.e even fakeperson://
This method is only exposed internally and the fakeperson URI is used there.
commit bd0f9cfe5be6dacb1530dde58ccc4993ff12daae
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Mon Jul 1 17:31:16 2013 +0200
Don't include using kpeople/
Otherwise we use the headers from the filesystem, which will be wrong
sometimes.
Reviewed by Aleix Pol
commit 4b4822ee2b42363036df9e1ed55fa76ac7aa5e31
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Mon Jul 1 17:13:45 2013 +0200
Fix previous commit to make MergeDialog works
reviewed by Aleix Pol
commit b3a7d1e70aa43074ffb326315e492d6a73af0b62
Merge: eb84a9f cebfd98
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Jul 1 15:59:33 2013 +0100
Merge branch 'sharedptrs'
REVIEW: 111308
commit cebfd98ca050dc2d387d76566931d8425ee22a8b
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Jul 1 15:52:58 2013 +0100
Update PersonsDetailView to use new PersonDataPtr
Plugins are not upgraded yet
commit d1f991dc01f2b5cd2f690d0c73768734fc8286b5
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sun Jun 30 22:23:45 2013 +0100
Convert PersonData to use SharedPtr
commit 3172220db5fdfde8a3b36e3ea61f5a94c13ac578
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat Jun 29 14:49:07 2013 +0100
Disallow changing URI of PersonData after creation
Currently setUri and setContactId are public which would cause a lot of bugs if changed.
Instead replace with two clear static methods; loadFromUri and loadFromContactId
A declarative wrapper using QDeclarativeParserStatus provides the same functionality
in QML.
commit eb84a9f5a261d0e6ab7b9b9ddadf23f7dbe79b47
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jul 1 16:55:44 2013 +0200
Return child contact uri instead of fake uri for fake persons
This allows direct pass-through of the uri; shields clients from uris
like "fakeperson:/N".
We concluded the client does not have to know if it's a fake person or
not, it was meant mostly for merging purposes, but we run uri
identification now, so this is not needed anymore.
Reviewed-by: David Edmundson
commit aef533620bb46b9893ba6e00255834fa40fc20ae
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sun Jun 30 09:09:34 2013 +0100
Fix setPerson method in details widget showing previous information
commit 035ba056572ce03c8885b4e6705a05de47d8fb6d
Merge: 9c19519 9bea022
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jul 1 14:59:33 2013 +0200
Merge branch 'cleanup'
REVIEW: 111309
commit 9c19519bba22ee8b3d6b50f372af5ddfd65ec64c
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Jul 1 14:25:12 2013 +0200
Fix compilation
commit a70f4d366e97ee6355a6ffabb789c05269d66f1c
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Jul 1 13:36:02 2013 +0200
fix compilation
commit ae45cca1f6cf80106dec36aa36aca4cf946d8cbe
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Mon Jul 1 13:11:19 2013 +0200
Merging contacts dialog and the example to make it run
This dialog shows all your contacts that have duplicates.
The list view allows to see the name of the contact who is
concerned by the merge and the photos of the related matching
contacts. When click on the item of the list, the view extends
to show merging contacts details : name+merging reason(ex:mail)
The effective merge is not currently working due to a known issue :
Nepomuk service storage issue, so it's commented untill it get fixed
Review Request #111165
commit 9bea0226105c4a4babf4886d42650c1435c06c0e
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 29 16:26:56 2013 +0200
Add Q_UNUSED
commit 3d1236829426cf5572be085cefd2c8c6f8eb7344
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 29 16:26:47 2013 +0200
Pass the contact's uri for update instead of the its ContactItem object
commit 3b3c71b6c2299efaf75e617438643237ad1293fc
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 29 16:19:33 2013 +0200
PersonItem no longer needs to be PersonsModel friend's class
commit 8fca58c087a3d541fd15db1fa960b735b2fa5caf
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 29 16:19:13 2013 +0200
Remove commented stuff
commit 150b0bb3f9249b18df1a4faefb3a42fb8b66dc23
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 29 16:19:00 2013 +0200
Fix MergeContactsWidget to use the new merging method
commit 341e54c036c6669f44907f7f0b694b0bbedb26fb
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 29 16:18:19 2013 +0200
Make addContactsToPerson and removeContactsFromPerson private
These serve as model data manipulation only, not for Nepomuk data
manipulation, therefore they should stay private
commit 08610a1f2c83360aa7765bd2830db7b74cfb2b81
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 29 16:17:23 2013 +0200
We can use contact's row() directly, no need to for index
commit adf862c77744fee34a0a644c3def8756fbfc41b0
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 29 16:17:02 2013 +0200
Move related methods together, less mess
commit cee9ee844344d2f5b91e8e70ac76b05b6bb19ac4
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 29 12:57:54 2013 +0200
Check if we actually have that contacts before updating
commit fc33b7d4e5498d0651c3354662b6bd73686acc46
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 29 12:55:57 2013 +0200
Don't update contact directly from resource watcher
commit 4aba37017348eac5d27db4f3de43fdb62ca4b257
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat Jun 29 08:58:17 2013 +0100
Handle imService failing to create a valid datasource
commit dd70cf1636fa65e6c16ebe9a288418a59f156ad6
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat Jun 29 01:30:03 2013 +0100
Fix tests
commit 406a95e4c2ec9fc2118eaaaa6a73f494498b08c1
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat Jun 29 01:28:15 2013 +0100
Add pretty header for PersonsModelFeature
commit 97851b5368087f1a26b16ca261eea8a53efb42de
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 29 00:05:36 2013 +0200
Major cleanup + new way of creating PIMO:Persons
This patch moves all data manipulation logic into the model itself. The
model now adds/updates/removes contacts, adds/removes persons,
adds/removes contacts to/from persons.
When there is any change, the chain is currently Nepomuk -> Resource
Watcher Service -> Model method. No more direct manipulation of data
from Resource Watcher Service or PersonItem.
Both ContactItem & PersonItem should serve as pure data containers and
have no model data manipulation logic.
Next change is creating persons from list of uris. It turns out that
passing indexes is unreliable as the role int values can overlap. So
then if we call data(UriRole) we can get totally different data and not
the uri.
This new method just takes list of uris and does the right thing (tm).
It checks the uris for their type, sorts them out and performs proper
job. Getting list of uris on the client side is easy as one can iterate
over view()->selectionModel()->selectedIndexes() and gather
PersonsModel::UriRole. The method also handles fake persons, so the
client does not have to worry about that.
commit 211efd7684402872fa2ffa409ec16f23a8931069
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri Jun 28 16:03:12 2013 +0100
Test PersonData update signals
commit 098357708cde9acfdbff1c5471d14d4a34ff4b46
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri Jun 28 17:08:01 2013 +0100
Start the resourceWatcher in PersonData
Found by a failing unit test.
Reviewed-by: Martin Klapetek
commit 645009cb4d8bbc7abe7bc5d80afa556de041b65a
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Jun 27 20:00:39 2013 +0200
Remove old & unused code
Revewed-by: David Edmundson
commit 228bb9082a3a7f84fdab8d8e18291f661b7dd2ca
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Jun 27 16:51:04 2013 +0200
Contact data must always be loaded only after it's appended to the model
commit 766fffb70bd29b889c03286d0a541d436c4eae37
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Jun 27 16:50:40 2013 +0200
Refactor creating new persons from resource watcher
Reviewed-by: David Edmundson
commit 676c47cca3743c1561149a0e6e86bc46f393670f
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu Jun 27 12:58:21 2013 +0100
Remove all traces of KTp dependency from the library
commit b077bc82c8bc66aad8738363f3824af8963ec2e5
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Jun 27 00:05:56 2013 +0200
Use startsWith() rather than left() + compare()
commit 1148e8821c7c11a9ba987709942bb2b03be8a7ab
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jun 26 23:45:47 2013 +0200
ChildContactsUriRole returns a list. Treat is as such.
Reviewed-by: David Edmundson
commit a4887c7deb434a88cea1d4b0deee281cef4b495a
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Wed Jun 26 00:23:29 2013 +0100
Expose PersonsModelFeature for queries in PersonModel
This allows users of the model to expand the data fetched at runtime
A QML wrapper that deals with the old bitmask is exposed to QML.
The QML version uses QDeclarativeParserStatus so QML no longer needs
Component.onCompleted() code
This makes QML code easier, and the C++ code more extensible.
REVIEW: 111249
commit 2a593fa54a3d43ee7690b709d3ce6ffd22e78f8f
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Jun 25 17:20:38 2013 +0200
Make offline avatars desaturated
Reviewed-by: David Edmundson
commit b469cad1ee8815d1ecaf6101cc4683a354db3aef
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Jun 25 17:14:10 2013 +0200
Don't exclude empty QVariant when collecting data from child contacts
Reviewed-by: David Edmundson
commit d9682929e23370b3d95ee39452bb5f13610c00fc
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Jun 25 17:13:35 2013 +0200
Return icon name rather than icon pixmap for presence
Reviewed-by: David Edmundson
commit f5d5d62325df0d0cbbdc8547837efc578859cdb4
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Jun 25 17:06:41 2013 +0200
Check for empty list, if empty, return immediatelly
Reviewed-by: David Edmundson
commit 0efce9cfb9d3ece4e56229d6d406f77c5e6c25bd
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Jun 25 16:43:24 2013 +0200
Add PresenceIconNameRole to return presence icon name
Some use-cases require it.
Reviewed-by: David Edmundson
commit 63b63d8a5f82a9031436d6219115769b2076d924
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Tue Jun 25 15:01:42 2013 +0100
qDebug -> kDebug
commit 75cd61d66dbaf61037747129a903027a02399a35
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Tue Jun 25 02:07:34 2013 +0100
Add pretty headers for the most important classes
commit 468a73441372b6d08a5be9462a2d23c83862d731
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Jun 24 20:46:21 2013 +0100
Add KPeople namespace
commit 26c9ca28afeb4e51403b84e74efeebd193ea8f6e
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Jun 24 20:26:52 2013 +0100
Fix previous merge
commit c0e5b1b3030ce4e50859a3a5d59bb047f564b13b
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Jun 24 19:08:37 2013 +0100
Remove deprecated widget code from AbstractPersonPlugin
commit 542bff0520e275aa3149b8235927f6c2583a678f
Merge: d578fb0 cc543b6
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jun 24 16:26:53 2013 +0200
Merge branch 'mklapetek/refactor'
REVIEW: 111096
Conflicts:
src/CMakeLists.txt
src/contactitem.cpp
src/examples/CMakeLists.txt
src/examples/personwidget.cpp
src/ktptranslationproxy.cpp
src/ktptranslationproxy.h
src/persondata.cpp
src/personitem.cpp
src/personsmodel.cpp
src/personsmodel.h
src/personsmodelfeature.cpp
src/plugins/core/email_kpeople_plugin.desktop
src/plugins/ktp-plugin/CMakeLists.txt
src/plugins/ktp-plugin/im_persons_data_source_plugin.desktop
src/plugins/ktp-plugin/impersonsdatasource.cpp
src/plugins/ktp-plugin/impersonsdatasource.h
src/plugins/ktp-plugin/ktp_kpeople_plugin.desktop
src/resourcewatcherservice.cpp
src/tests/duplicatestest.cpp
src/widgets/CMakeLists.txt
src/widgets/abstractpersondetailswidget.cpp
src/widgets/abstractpersondetailswidget.h
src/widgets/persondetailsview.cpp
src/widgets/persondetailsview.h
commit cc543b6063205323da909cebb101cc08881430d0
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jun 24 15:55:00 2013 +0200
Watch for nco:nickname
commit d578fb0336d1f011eb1bdb44832e7a74324fbb63
Author: David Edmundson <david at davidedmundson.co.uk>
Date: Mon Jun 24 13:00:09 2013 +0100
Update PersonDetails example to use kpeoplewidgets
REVIEW: 111205
commit 10e887710470ee0aa21ed42ca8c0c63224057e48
Author: l10n daemon script <scripty at kde.org>
Date: Sun Jun 23 04:04:57 2013 +0000
SVN_SILENT made messages (.desktop file)
commit d5d00d4f5d1e31e19bde5d17fd200c0aa99da5b0
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Jun 23 00:15:09 2013 +0200
We're not Analitza
commit 1cee6479a62a7a5380dd7f85ca8e729b741f09f9
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Jun 23 00:12:13 2013 +0200
Reenable duplicates example
commit 94523fa8ea84837e03ea202c2c3e28fe2e909b4b
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Jun 23 00:11:59 2013 +0200
Get ContactItem from PersonsModel directly rather than through indexes
commit f74b99d9bcada7512f4dcc55bca7df394644c81a
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Jun 23 00:11:33 2013 +0200
Remove some old stuff, looks like merge leftovers
commit 139217593ca27e9ee50303cc28485b468a0b1b81
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Jun 23 00:08:39 2013 +0200
Get rid of updateContactNextReady() and use nextReady() instead
commit 31a65c974965e2ce304e63341c21b48b2fa873a7
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Jun 23 00:07:27 2013 +0200
We can load contact data only after it's been added to the model
commit 325da2035ef88f18cd1b07f234965b84a8adbbfb
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Jun 23 00:07:03 2013 +0200
We need to create new fake person when adding new contact
commit 79dd687609e06c7b992e98cdf38c5b477d8e4f4b
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Jun 23 00:06:30 2013 +0200
Make the nextReady() method work for updating contacts too
There are also some optimizations given the fact we now have everything
a person.
commit 92fb02a301c217d3cdcc57b608c1fc7a76585b31
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Jun 23 00:04:12 2013 +0200
Replace static counter with private int
commit 12dd627445469a7404c528d361bed9af73f36380
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Jun 23 00:03:20 2013 +0200
Empty QVariant is perfectly valid return value
commit c61024eab9afbc082069a7e5f16c72d9bd494437
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Jun 23 00:02:38 2013 +0200
Update parent PersonItem when ContactItem update finishes
commit 3c6489f47f4cedeedd07a15a842f19fccd37d0bb
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Jun 23 00:01:17 2013 +0200
Change contactForIMAccount into more useful contactItemForUri
commit 2d2b529a5227f21bb796d2ba8714d345a324f7ab
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 22 23:59:08 2013 +0200
Update roles
commit 2417bffdcbb035e31766dde7f883bd27a069a401
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 22 23:57:42 2013 +0200
Contact node can be updated only if there's valid PersonsModel pointer
commit 36cc3b252d306c6e8d3b63be45191de8b46308e5
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 22 23:57:01 2013 +0200
Don't insert empty values as contact data
commit 63d9ec907c5e95f8475b3f0426aa16d2d4c20308
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 22 23:55:44 2013 +0200
Remove useless while loop
commit 7bab277339a9171798c45fad83da262615682d0e
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 22 23:55:23 2013 +0200
Cache KTp::Contact from contactForContactId call
commit 65e8c5aaffe395dd11b223852056ea5314982b8f
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 22 23:54:31 2013 +0200
Make the kDebug output a bit more usable
commit c85764f53ea8b8f5caaa83887fa7d704d899a95d
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 22 23:54:06 2013 +0200
Remove the IM watcher
This was used only to watch for nco:imNickname change because this
property is on nco:IMAccount rather than on nco:PersonContact. Recently
the Telepathy feeder added nco:nickname to nco:PersonContact itself,
which means we don't have to watch nco:IMAccount anymore. Was broken for
some time anyway.
commit c9f8733ffe481ba42abb9ce62be6af4f0c9c0500
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 22 23:52:06 2013 +0200
Remove old files
commit 8cbe719579928998450ca24a9b0d205ca746e958
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 22 11:57:03 2013 +0200
Add mergecontactswidget.cpp to CMakeLists; fixes build
commit f686583ba11d09fee1318d652e544ba42fd93ada
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Fri Jun 21 16:25:33 2013 +0200
Make sure we don't report a finished job too early
Register the jobs as done when they finish. Only return from startMatching
if there were no matches.
Aleix forced me to commit this
commit a648f6eb39f8aff387acd2b18ba275d64ab0fe86
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Fri Jun 21 16:23:11 2013 +0200
Merge Widget for the PersonDetailsView
Adding the Merge widget for the PersonDetailsView , so that the user can
see and merge duplicated contactsding the Merge widget for the
PersonDetailsView , so that the user can see and merge duplicated contacts.
REVIEW: 110972
commit a129c37767702f4ebd44430fa2b6a37e904e49ff
Author: Franck Arrecot <franck.arrecot at gmail.com>
Date: Fri Jun 21 13:18:30 2013 +0200
Don't match contacts by empty fields (mails, phones)
When I was searching for duplicates, it was retrieving contacts in a random way
since both of them had an empty field in his property. This patch solves it by
skipping empty fields.
Reviewed by Aleix Pol
commit dbeb5741977101caf7cc4ac034ade48ccd226022
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Jun 18 16:01:04 2013 +0200
Remove old files
commit 39a229f6839964f15141e28a778b62927f4049cf
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Jun 18 15:39:14 2013 +0200
KTp translation proxy improvements
commit 03d6235454a64f9c8b0f34c15a35cca7fbdab3f7
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Jun 18 12:20:59 2013 +0200
Remove looking for most online presence in the translation proxy
This is now done directly in PersosnModel, no need to do it twice.
commit 302aa6b9be2ce75336c395ee96807a46eec34673
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Jun 18 12:20:10 2013 +0200
Make PersonItem return the most online presence type, icon and name
And make it more efficient too.
commit e992e3ad57c0cc3e2748cbd5685b3fbf58a8d3b4
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jun 17 20:19:20 2013 +0200
Cleanup
commit 5eb6e6db68038d68d96e59267b2647dcd0772626
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jun 17 20:19:08 2013 +0200
Query child contacts for UriRole when ChildContactsUriRole is requested
commit 8d04a2f6361817245d778ea9e04dc62ab3448ff4
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jun 17 20:13:34 2013 +0200
Use new roles in duplicates finder
Test passes
commit b6486a08ea78cead0ecaeeffb33306db5cf2ef5b
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jun 17 20:06:23 2013 +0200
Pimo:Person uri will never be empty now
If the contact has no pimo:person, a fake one will be created for it.
That means no checks for empty person uri are needed.
commit 1556113e27f8a4fc5e21464baa6636f1a3f612c7
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jun 17 18:24:43 2013 +0200
Fix role used in PersonsModelTest
commit ca52975088de311bc939232fa762325ecf67f45f
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jun 17 18:24:17 2013 +0200
Add presence message to the translation proxy
commit f7c09b2bafb75376f8a3206c9a6c7d805327872a
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 15 13:25:16 2013 +0200
IMAccountTypeRole is unneeded
commit 560cfb250db049dcaf50ba41c8ea36adab93ed59
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 15 12:06:20 2013 +0200
Remove unused variable
commit a56ae74473b1e6a608d21cdf4bf488295569f950
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 15 12:02:28 2013 +0200
Make the KTp translation proxy work properly again
commit 9063fd2df0f9b03f83406ca475e2f0eced86e2c3
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat Jun 15 12:01:59 2013 +0200
Add a nepomuk query to get Tp::Account from simple contact id
If the KTp contact is null, we still need the Tp account for that
contact so we can either group it properly or bring that account online
if user starts a chat with a contact that belongs to offline account.
Nepomuk stores the account identifier, so we can retrieve it from
Nepomuk directly (it's impossible to retrieve it from Telepathy if that
account is offline).
commit 794adbff50c3e489b943f360930f43c7c6ea88f7
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Jun 14 21:42:03 2013 +0200
Remove traces of the old s_imPlugin from ContactItem
commit 4af12569943fc442e1f26a3251e2665f33a1700c
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Jun 14 21:41:39 2013 +0200
Return person uri properly
commit 7793acbeefd069a855e988a13520e20eab6c557d
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Jun 14 21:41:25 2013 +0200
Implement most online presence returned by person
commit 4e874152becd12af5c21d75e395ce977a859fe22
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Jun 14 21:40:01 2013 +0200
Reenable contact merging
For contact merging we need the contact uris and for that we need a way
to retrieve it from the fake persons (which represents the contact).
Since the model will be used with proxies, we can't guarantee that
index.child(0,0).data(...) will work, so we need another way to access
that contact's uri. So I added new role called ChildContactUriRole,
which returns the child contact role and it's meant to be used only with
fake persons.
I'm not sure this is a good idea, needs proper reviewing.
commit 5ccff4e608377d7787da300e7fd0fe1cd4be461c
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Jun 14 19:46:11 2013 +0200
Add a comment (forgot to stage with prev commit)
commit 695675fec992c4c76afa7210998fd9e0b1df3e77
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Jun 14 19:44:25 2013 +0200
URI role also must not be a list
commit 5d757f09731f420ec7e30107d13a0798451a9a2f
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Jun 14 18:03:00 2013 +0200
Return DisplayRole & DecorationRole as QVariant, not a list
commit f1c2f51c6d71838f89c6a35b3b96c1d23d84d316
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Jun 14 18:00:15 2013 +0200
Return "Unknown contact" instead of "Unknown person" on contact level
commit 25bc9398654d22ec0954161825f95157eed3a5cb
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Jun 14 17:23:37 2013 +0200
Rebase on master
commit 22a4a1fd6a88720d8ee53276086d0f9c903a0f11
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Jun 14 12:04:42 2013 +0200
Add missing assignment operator method; fixes build
commit 07da0b244b82c1fd6518cf6a29fdc6a8aa7998c5
Merge: 85afd62 23bde31
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu Jun 13 22:09:27 2013 +0100
Merge branch 'modelfeatures'
REVIEW: 110961
commit 23bde3163bf094378c64b7d5c6bbaf67a557c244
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Tue Jun 11 17:55:17 2013 +0100
Update PersonsModel to use revised PersonModelFeatures
commit 2cdb5954a13999d45b0efb446902999388f5c95b
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Tue Jun 11 17:54:56 2013 +0100
Prepare PersonsModelFeature for being public
Set PersonsModelFeature to use QSharedData
Add documentation on methods
Add static methods to create common PersonModelFeatures
commit 85afd62a540c895c0e5938c02433711ce78b1548
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Wed Jun 12 00:24:10 2013 +0100
Fix tests
commit 2d8e2064d01863a41565e944a01d5ed003c15ff1
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Wed Jun 12 00:20:28 2013 +0100
Slightly optimised setContactId
commit 279926f59d291e2893212a2e52248e16a03978b7
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Wed Jun 12 00:20:13 2013 +0100
Re-enable PersonDataTests on invalid IDs
commit d16fda3a922a6f0808d8df0366f4130b30421e77
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Wed Jun 12 00:18:04 2013 +0100
Fix crash in PersonData::name by checking we have resources
commit 86be67ca24633a1cc2d4ed0bd96c7d7be1263c4c
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Wed Jun 12 00:16:06 2013 +0100
Add missing Q_D
commit 96d358abdbb28850f081fa2fa6f880dd415cc5f2
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Wed Jun 12 00:14:41 2013 +0100
Add PersonData::isValid()
commit 36b4d1ac750351d3f290b4e09592cc3afb54d1fb
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Jun 11 18:38:29 2013 +0200
Fix merging from QML
The merge method was removed, need to adapt to newer API's
commit e194cf73d4d6cb358b0b5faf913c463f2a13024c
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Jun 11 18:28:58 2013 +0200
Add some asserts to make sure we crash when something is weird
I had some crashes in QML that gave me weird crashes in Nepomuk code, it
doesn't hurt I'd say
commit 71b79846b83da0756bb73571947dbfa0728d9daa
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Jun 11 18:15:37 2013 +0200
I guess it doesn't make sense to have the find duplicates stuff inthe model
commit 1cfb5688953e60762b0eb7c8905eb860699749f4
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Jun 11 13:08:10 2013 +0200
Also search for the kpeoplewidgets library
commit ceb70b525670f5850a77bff7816bdf75966577e8
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Jun 11 12:45:24 2013 +0200
Install the PersonDetailsView class
So that it can be actually used
commit 84a1ab6d939691e4598a6ee646518373410c8dfc
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Jun 11 12:45:02 2013 +0200
Fix PersonData constructor and proper use
PersonData has 2 constructors that had a disjoint construction path that
would leave the class half-constructed depending on the case. This patch
fixes it so both are usable.
Also makes use of it from PersonDetailsView, which was crashing because
it was being constructed with an empty Uri.
commit cd17c3be022f1f202cc4ae843fe24aeaefd4108a
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Jun 11 12:27:21 2013 +0200
Fix the cmake finder
Modify the cmake finder to find kpeoplewidgets as well
Properly find the kpeople include directory
commit c3948d424c80b69b372b6774348787f0ea64e750
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat Jun 8 00:49:40 2013 +0100
Do not leak d pointer in PersonsModel
commit a1965ad1fd3478a3c4148e60ac4a5107ecfc5185
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Jun 3 13:45:12 2013 +0100
Monitor for changes from PersonsDataSource
Add a new class DataSourceWatcher that monitors speific contactIDs
PersonsModel and PersonData are then updated to use it.
ContactURIs are mapped to save searching through the entire model
REVIEW: 110801
commit c3103a4c479c26889b853cda722feb55ef7c4857
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Jun 3 17:17:43 2013 +0100
Group multiple contact fields on the server
Normally a contact with multiple email addresses (for example)
will appear as multiple rows in the query.
Currently our model does not handle this and multiple emails/phones
etc. are missing in the model
By using group_digest we group all values into a single list on the
server
REVIEW: 110817
commit c5818effc3694e36f58faf34118895cd1407a240
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Jun 6 15:54:42 2013 +0200
Fix duplicates example
Wait for the model to be populated before starting to look for duplicates.
Otherwise it only searches through an empty model then it exits.
commit 67bca3262174a914aea559118280a5e5676b2744
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Jun 6 15:42:22 2013 +0200
Don't initialize the model before QCoreApplication
Nepomuk doesn't like it and it's ugly anyway
commit 1a2427cf8a5eebab88b5df5fa0b829a6b4f8a3b3
Author: Dan Vrátil <dvratil at redhat.com>
Date: Tue Jun 4 14:36:46 2013 +0200
Fix some memory leaks
Always free the private structure :-)
commit aafb13c6b87b3eb45eb1f0350ee2e2b13d4d0e7e
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Mon Jun 3 17:19:11 2013 +0100
Add reviewboard file
commit 185b0a662b779670341cbe2ffb7df744ad490cc4
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jun 3 16:07:15 2013 +0200
Fix tests to use the new signal name
commit b27cd5fb4ec3c9d37c11033f4c92913d8f39638a
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jun 3 16:04:18 2013 +0200
Rename peopleAdded() signal to modelInitialized()
...to not confuse people (pun not intended).
REVIEW: 110691
commit 612384340287c6fcaad030b52d6c70844b28e822
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jun 3 16:02:42 2013 +0200
Make sure PersonData checks the same data for names as the model does
REVIEW: 110692
commit a026affc370bf02ca9c3b6e1ba016e54db091684
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jun 3 16:00:10 2013 +0200
Don't use hasProperty(), just iterate
Saves one qHash(QUrl) because of Resource::hasProperty
Reviewed-by: David Edmundson
commit a75d08e400d09e3564e2670783074daf47f00c58
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sun Jun 2 15:03:14 2013 +0100
Optimise indexForURI
REVIEW: 110781
commit ebbcc8e518d9dad2da5270adaf55c36caa63cd0a
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sun Jun 2 22:55:28 2013 +0100
Remove unused forward declaration
commit b079ec523f12b473b0fa5ab0397146f57a25e67d
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sun Jun 2 16:40:43 2013 +0100
Remove unused code
commit e1f7160b1bc89b9ba2c54c57adc4297c13433de3
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat Jun 1 03:29:12 2013 +0100
Return KTp::Group role from PersonsModel
commit 2b2366e03f23e81edd88d465de5f69b42beffa88
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri May 31 19:08:57 2013 +0100
Do not try to install file that does not exist
commit 05c4ab15ad8c14ae0fbcc5bd460a0f72832454bc
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri May 31 19:07:31 2013 +0100
Fix compile referencing installed files
commit 86119acf81a5169e72d343bf05ddb42b24ef7444
Merge: 58c6fef 4c72065
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Wed May 29 16:00:29 2013 +0100
Merge branch 'widgets'
REVIEW: 110711
commit 4c72065720758942f93b9b1579b6078e5062dfea
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 01:10:19 2013 +0100
Re-enable core person details widgets
commit 9c98f82df2b27a8504546aec1f72247520137c32
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 01:06:57 2013 +0100
Update export on PersonDetailsView
commit 98d9f31d5fcf7b7950b8af70d1122562d6cf0698
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 00:57:59 2013 +0100
Add widget library with initial class to view contact details
commit 58c6fef04800fc7e25504375610bf9de1d1faac3
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue May 28 19:08:16 2013 +0200
Fix the contactlistqml example
It was not even starting, again.
PersonsPresenceModel is not available now
Fix initialization of the model
Properly expose the methods that are supposed to do that on the model class
Reviewed by David Edmundson
commit c75b5b006bccb605eaec0314950ad4f241ec7faf
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Tue May 28 03:43:49 2013 +0100
Add tests for isPerson and contactResources
commit 160e3e3a50ab11a3bc3a7172b30aa644140ab0f9
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon May 27 19:55:08 2013 +0200
Fix installation
The file doesn't have dashes anymore
Reviewed by Vishesh Handa
commit 8d125ded8d63bdbeaee917f1bbdc7c119418158c
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri May 24 20:06:29 2013 +0200
Give useful names to KPeople examples
I hope people will like them a bit better now.
Reviewed by David Edmundson
commit 1899482bff2c718b7c203a24b0956502c684a453
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri May 24 17:54:51 2013 +0100
Make methods that should be private actually private in PersonsModel
commit 67762ea28698f8ffd3a008e58cc890a1b0e82fee
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri May 24 17:44:56 2013 +0100
Move public signals to be next to public methods in header file
commit a6e834be8a3d8b25fc782af33b7882d981f40a59
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri May 24 01:34:31 2013 +0100
Remove friend class to a class that doesn't exist
commit af49e7d57d6b2d4066f1b2bedbcbcafaadf33462
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri May 24 01:23:39 2013 +0100
Rename createPerson/createcontact to addPerson/addContact
This better reflects the action in the method
commit 7f11a0c36ddb5852120bfb9b34e999eb831b5967
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri May 24 01:18:43 2013 +0100
Remove unused commented out code in PersonData
commit 913e7d0b8dd874cc77351713671e3332c8d8107b
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri May 24 01:17:24 2013 +0100
Update classname of PersonsActionsModel to match filename
commit ed9a5b5f8d3a287b0060519a55a4168e0fe9c335
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri May 24 00:34:09 2013 +0100
Fix setContactId
For some reason using Soprano::Query::QueryLanguageSparql works where
Soprano::Query::QueryLanguageSparqlNoInference does not
commit 1d93bbc76635cbe2eebb932ada6f29b714861295
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri May 24 00:32:41 2013 +0100
Add warning if test data insertion fails
commit ba1fa6a48eb11db5397257bdfc6beeed83be1997
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 23:54:57 2013 +0100
Reinitialise nepomuk data after TestData::cleanup finishes
commit 3ae432e3d55b429568f0e21d62dd383d9812a7b0
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 22:56:52 2013 +0100
Add tests designed to make PersonData crash
Disabled for now because it makes PersonData crash
commit e3b51590208fa34b643db9da64cf16578db48d80
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 22:49:29 2013 +0100
Disable building the tests which are useless
commit c6aa17bd1eb4418c87fda2f22c2edb7a5efbd242
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 22:48:15 2013 +0100
Tidy test code
commit e2a4627b1e4320030a4a85cd36f980a7c2573487
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 22:47:35 2013 +0100
Add Person to Nepomuk Graph in test
commit 67f1d02f9e3b086e678af8b6ec25c8d55b68cb33
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 22:38:11 2013 +0100
Add test for loading a PIMO:Person from a given contact ID
commit 9c4b6db35a48d2c7320a00209256b5db0a92a301
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 22:36:01 2013 +0100
Add test for properites from PIMO::Person
commit 2e0d74789c3aeaf2556e69b57769b6bcb5da79ad
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 22:32:42 2013 +0100
Initialise a person with 2 grounding occurences in tests
commit 2dab2bd2ae31931432d92bbcf723af5a280879b5
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 22:25:28 2013 +0100
Add test for creating a PersonData from a contact ID
commit d055552b49cfd25bd4cf1e6bd49ccf0ed4bfef4a
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 22:23:38 2013 +0100
Split PersonDataTests contact initialisation
commit 332ef2798327ff7b63d6978fe9901e6c7162609a
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 22:18:17 2013 +0100
Fix cmake to include nepomuk test tools
commit 0764420283c5c0723c8e36b87027a57922bcdf11
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 23 00:03:55 2013 +0100
Fix compile
commit e31f421ae6e9b301ac42094fcffb3004cb532fc5
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sun May 19 23:50:54 2013 +0100
Fix example
commit 185ddbbbaff08daa24c883cb0d7d321a65984e03
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sun May 19 23:38:40 2013 +0100
Fix scope of slots in MatchesSolver
commit 80ee58f031d9811eee07daedf111f7a9573fbd75
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Wed May 22 23:47:52 2013 +0100
Rename PersonActions -> PersonActionsModel
because it's a model
commit c8b0d103fe24ba5967f74a431f87050c1e223919
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Wed May 22 23:44:45 2013 +0100
Remove original PersonDataTest
Deprecated by test in autotests folder which does it properly
commit 4d541bdf706bdcfb546aac4ae106f24cdeaf91b5
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Wed May 22 23:43:33 2013 +0100
Remove unused code
commit e4d56ef2d1808b1807ac60c44a04087e00777637
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Wed May 22 22:16:46 2013 +0100
Rename all files to consistent naming
commit 355a89ddaca5773d8e59749f6a4bdd20ed8af3ff
Merge: 3b29905 bf1b906
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Tue May 21 22:03:55 2013 +0100
Merge branch 'unit_tests'
REVIEW: 110503
commit bf1b9060ebd8e161c9e78a502483f21b673a4b81
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sun May 19 02:47:06 2013 +0100
Address review comments
commit 4f78132b643d9caf6ad2114a1b75906979ee940a
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat May 18 14:23:10 2013 +0100
Add test for PersonData class
commit 446e8bfe18b3a3220c3e783045f78fc571866432
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat May 18 14:22:51 2013 +0100
Add Nepomuk test library
commit 3b2990591c19596b7c3902c391ce10b44a39e711
Author: Script Kiddy <scripty at kde.org>
Date: Wed May 15 09:04:18 2013 +0200
SVN_SILENT made messages (.desktop file)
commit 04af7edf54a1e3f4a967789ced84c8b59ffcd454
Author: Script Kiddy <scripty at kde.org>
Date: Tue May 14 17:39:08 2013 +0200
SVN_SILENT made messages (.desktop file)
commit 3831d80e1de9d6f936a94d76f353dd6a3a81560b
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue May 14 12:51:05 2013 +0200
Fix build
commit fcc32fe2e09795522dccf2ab95a62941afab6f33
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon May 13 15:55:57 2013 +0200
Removing PersonsPresenceModel; switching to IMPresencePlugin
This disables the PersonsPresenceModel and uses IMPresencePlugin for
presence data instead. Also the translation proxy now implements KTp
stuff directly, will be moved to KTp eventually (same for the plugins).
This also adds a temp workaround for linking against the
IMPresencePlugin - the cpp file is added to kpeople sources. This will
be solved when we move it to KTp.
PersonItem now always returns a list for all data except of
Qt::DisplayRole and Qt::DecorationRole.
Currently we miss a contact update system - the presence plugin emits
contactUpdated() with Tp id, we need to translate this to some model
index and emit dataUpdated() for that index.
Reviewed-by: David Edmundson
commit e5550f59f554051f6dc46aef72c7bfdb1926d8b5
Author: Script Kiddy <scripty at kde.org>
Date: Mon May 13 08:45:57 2013 +0200
SVN_SILENT made messages (.desktop file)
commit 6ca924603ac307e3f10b4e8d3b1b79ceff350f13
Author: Script Kiddy <scripty at kde.org>
Date: Sun May 12 08:52:25 2013 +0200
SVN_SILENT made messages (.desktop file)
commit df98d1f50509c0a77e4bcc84903d7ac76d5c67c1
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sat May 11 14:08:11 2013 +0200
Cosmetic fixes
commit 8f6366961065bd0c6a740893cea2b14c0bbb1a0f
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat May 11 11:51:23 2013 +0100
Fix IM Plugin to provide actions for KTp contacts
Added a new file so that that im-persons-data-source can be used in two libs
without plugins crashing
commit 749d277cd4695a607cb81f1d7092e234c3abde06
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat May 11 11:50:58 2013 +0100
add export to PluginManager
commit b72bed2a0a4fa04cff97f07ab35e647ebf352f34
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat May 11 11:50:36 2013 +0100
Remove useless debug line
commit 866f29db4b1289ed6d54470f55a0e109f1b26c61
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat May 11 11:23:42 2013 +0100
Add service file for kpeople plugin
commit c09c1fb100303bde45cda6b7e24b122146ba66a3
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Sat May 11 00:26:07 2013 +0200
Move actions to a real plugin system
commit 0df0dc77f0e52fb2774f3a2784c01bf05332f9ee
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri May 10 21:28:29 2013 +0200
Add missing consts
commit ab385ca9b0f6ad6ffbd720a37a7e909d99ff80e9
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Fri May 10 21:13:14 2013 +0200
Make PersonsPluginManager act as a singleton
Also make it ABI safe.
commit 0410da20a56ead2c86340550bc89d7a05b6a27af
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri May 10 20:50:30 2013 +0200
Add file transfer action and log viewer actions; small fixes
Reviewed-by: David Edmundson
commit 950dacee26de66bc92908b21154cbccfdb518c0f
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri May 10 20:49:49 2013 +0200
Add basic plugin for getting Presence data from KTp
Reviewed-by: David Edmundson
commit a2433a308a7b0be1f78d89c44476d058e8fff2e2
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 9 21:07:51 2013 +0200
Add plugin for emails
commit 93abd19a7e0a7822718772dac7fa7b21a78fd1c1
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 9 17:20:08 2013 +0200
Use correct email address for David Edmundson
commit fbd20c03c90c0674b943639f8f28e5db6353c028
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 9 17:18:23 2013 +0200
Expose contact resources
commit 63bd40f77a575e53700ec08bf72797fd143dd172
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 9 17:18:14 2013 +0200
Use the new actions plugins
commit e5bc7c3fedd24d1af6596411e59554498ec9050d
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 9 17:17:38 2013 +0200
Guard crashes in IMPlugin
commit c799a94c9a923474edfd27a9af034d61b1a321dd
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 9 17:17:05 2013 +0200
Initialise PersonActionsPrivate
commit a64ba1fd5048d208421ab12aaa7cdfe0643a1e7b
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 9 17:13:54 2013 +0200
Add missing header guard
commit 308ffb154441803fed82247f427732626f737566
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 9 14:54:06 2013 +0200
Upddate PersonsActions to use plugin system
commit 08acffbb89ab2bc0ec05500a4aaf8c70d9e7b10a
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 9 10:15:24 2013 +0200
Move IM plugin to plugins folder
commit 1d90d6f4cc4dcf77f76ecfe48b38a576f27763f0
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 9 10:15:20 2013 +0200
Move IM Plugin to plugins folder
commit 6a905d1d390cee8fc576eaf9622d4dd4a5f02779
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu May 9 19:21:44 2013 +0200
Initial refactor commit
Contains /lots/ of changes, highlights:
* new plugin system for getting IM presences
- makes it possible to separate between (K)Tp and KPeople stuff,
deprecates PersonsPresenceModel
* new data structure, everything is now a person with subcontacts
- where it does not have a real PIMO:Person, a fake person is
created. Because of this fundamental change, everything is broken
and for now commented out, all needs refactoring.
Note: I don't like this change, brings no real advantage,
but more skilled people decided for it, so I trust them.
* contacts on Nepomuk change are loaded asynchronously
- loading was moved to the model
* some other changes
commit 4d9b12df5700f6ab6d322614bbdaea9636136cd5
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 9 09:43:10 2013 +0200
Add missing Q_OBJECT macro
commit 9c33c8b7a0d3a6a9362592f90a6c55e8ebeb4599
Author: David Edmundson <kde at davidedmundson.co.uk>
Date: Thu May 9 00:54:48 2013 +0200
Add start of plugin system for person actions
commit 49fa3ab50d935f428ce49dc9199ec68a09a6fbf4
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri May 3 16:59:35 2013 +0200
Simplify PersonData code
Now the class stores contacts (grounding occurances and signle contacts)
in QList<N2::Resource> and always simply iterates over the list.
REVIEW: 110278
commit 4b881f7cce82d57cb9c9ccd3a1e7255834a9fb2b
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Apr 29 11:24:27 2013 +0200
Add method for accessing contact's groups in PersonData
REVIEW: 110200
commit 14fcbc8c14c494ce2a69056d425360269d923057
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Apr 25 16:48:15 2013 +0200
Watch only for model changes of the current contact in PersonData
Reviewed-by: David Edmundson
commit d114b93e6ddc50a80b978281108fadfa6c5f6200
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Apr 25 16:46:21 2013 +0200
Add birthday into PersonData
Reviewed-by: David Edmundson
commit 1d9593b72d3e5ae3c1ed688b953b741f221b5a8f
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Apr 24 17:20:29 2013 +0200
Replace rows with indexes in matchessolver.cpp
commit 056aceaf47b48652140d0181d2a49f188a1e82ae
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Apr 24 13:20:33 2013 +0200
Add only contacts from the watcher that we are interested in
If we request IM only contacts from PersonsModel and then akonadi feeder
kicks in and starts feeding its contacts, resource watcher catches that
and puts new contacts in the model. This wasn't a problem before as we
used a proxy model to filter out contacts we don't want. With the
Features in place this is a problem again.
This patch removes the contactCreated slot, which put the contact in the
model, and instead puts the contact in the model while we receive
propertyChanged() signal. This is because the resource watcher "works"
in two phases - each new created contact is signaled first and then for
each new created contacts its properties are signaled as
propertyChanged(). With propertyChanged() we can check what type of
property is being added (this information is not present in
contactCreated()) and if that property is the one we are interested in
(defined by the features) only then we create the new contact in the
model.
REVIEW: 110128
commit a47cc1d0b2215642b7f4b3482dc506934d85bb3f
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Apr 24 13:02:53 2013 +0200
Use indexes directly in duplicates finder + add model method for finding duplicates
The duplicates finder right now stores only the row of the matched
contact. Whenever we want use that, we need to create an index from it.
This stores the indexes directly and emits the matched indexes. The app
should listen to this new signal and should display it to the user for
confirmation. Once user confirms, it will take the indexes that user
confirmed and pass them to createPersonFromIndexes(..) method, this will
be part 2 of this patch.
REVIEW: 110134
commit 3bddb55110acbe5c6897d8dd3f6064914fc80953
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Apr 23 12:59:43 2013 +0200
Remove deprecated methods
REVIEW: 110124
commit 4f4827ca06fbe5db717044aee0532651a4fc77f2
Author: Dan Vrátil <dvratil at redhat.com>
Date: Wed Apr 17 14:43:57 2013 +0200
Allow compiling against KPeople with -DQT_NO_KEYWORDS
commit 404170340998d2fe8830efcf07207040839cfbb1
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Apr 5 04:23:30 2013 +0200
Add missing PersonsModelFeautre files
commit 91c640e5590b754f808155b0af273d736e3c1bb5
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Apr 5 03:31:51 2013 +0200
Codestyle++
commit 151b72fba487bf5f8bd4ff96ce28aca82dacc3dd
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Apr 5 03:30:23 2013 +0200
Get nco::fulname properly from the contact
Reviewed-by: David Edmundson
commit 54ada79a2ba202ed006b1f2b6b9bc2aa8d0b91ea
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Apr 5 03:29:13 2013 +0200
Missed part of the "presence as string" commit
Returns the string in PersonData now instead of Telepathy types
commit 20bc32c8c85218ae73d4f9c07e506ee1fb9cc485
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Apr 5 03:27:59 2013 +0200
Add missing NameRole querying into Qt::DisplayRole data
commit 2ade0ad75284ff845d947fccc12efa3291d78839
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Apr 5 03:26:55 2013 +0200
Add presence string role
This returns presence names (which are strings) alongside Telepathy
types, so we don't need to include Telepathy files in client
applications and still show presences.
Reviewed-by: David Edmundson
commit 26306490ad609b45c02dabe55eae35c106b50e61
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Apr 5 03:23:28 2013 +0200
Remove ContactType
Since nco:Contact can have multiple contacts of different kinds, we
can't mark contact as "email contact only".
Reviewed-by: David Edmundson
commit 77041dd89cac6bd12e33d62603b551eeb95d7867
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Apr 5 03:21:34 2013 +0200
Add a way to construct a query using flags
This allows us to pseudo-dynamically construct a query from prepared
"features", so each client app can ask for things it really wants/needs,
for example only contacts with email addresses, only IM contacts with
avatars etc. Another set of flags sets optional features (equals to
OPTIONAL {...} in SparQL), which retrieves contacts that both have and
not have the selected feature, eg. avatars (some contacts don't have
avatars, but we still want to have them in the list).
REVIEW: 109833
commit 19ab77e1d676d49b93cdf9ce8ce8156458841521
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Apr 2 17:18:29 2013 +0200
Add FeatureRosterGroups to handle contact moving between groups
Reviewed-by: David Edmundson
commit 4f1357d2e783cfa0cc1a7a4abbea0256d481bbdb
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Apr 2 15:51:00 2013 +0200
Add getter for Tp::AccountManager
Reviewed-by: David Edmundson
commit f8ca0e93c31a59cd2f639597e0ea6f0f45b9c842
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Apr 2 15:50:18 2013 +0200
Change dptr variable names to not have m_ prefix
commit 5d2c9969194bd06448b10025db788e8d6fba88de
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Mar 26 12:17:53 2013 +0100
Remove useless kDebug line
commit 6e8944d07a4017e3595d5c86e0eeaf27e26b4b0f
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Mar 25 17:26:35 2013 +0100
Remove Person if it has only one grounding occurance left after removing subcontacts
There's no point in having a metacontact with just one contact,
so we remove the grouping and put the subcontact back as a toplevel
contact.
REVIEW: 109640
commit 9c8f3ec206935901044599424142cffdb60a1fbe
Author: Aurélien Gâteau <agateau at kde.org>
Date: Thu Mar 21 15:41:21 2013 +0100
Fix compilation. For real.
kpeople/persondata.h is not available before "make install"
commit 7ec2a0bb160f12c834c8609a4dcedcba142c18b8
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Mar 21 12:39:52 2013 +0100
Add Tp client types support in presence model
Reviewed-by: David Edmundson
commit 4e0cdce09f9924e8403c9a575cd97a03a85b9bcd
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Mar 21 11:59:08 2013 +0100
Switch from string presences to presnce types
Makes our lifes a whole lot easier.
Reviewed-by: David Edmundson
commit 8a9c35785c28d6c0242aae3752a55942c6b47a24
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Mar 20 19:53:36 2013 +0100
Simplify semantics in internal contact data feeding API
Change the ContactItem internals to store a QMap<int, QVariant> instead of
a multi hash. This way the type of the role's data will be always the same
that has been fed and this will be controlled by whoever calls
setContactData (so it requires documenting the roles). Also make sure that
when we change some of the data, it still has the same type as the former.
Rename ContactItem::addData into ContactItem::setContactData. addData
could have meant that the provided data could extend the value of the
set value. I think it's better explained with the current data.
REVIEW: 109598
commit fcf18738f0a56e7bc78c11790e9070448830d6b7
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Mar 19 19:38:52 2013 +0100
Expose the decoration in the PersonsModel
This way the PersonsModel will be easier to embed, especially if we use
standard delegates.
REVIEW: 109587
commit 69a0c0e398802287e08f01b76d15434f229d7344
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Mar 19 19:12:34 2013 +0100
remove unused variable
commit c04a7fdd5fc331956ea2cb3b20be19fb9e7946a4
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Mar 19 18:26:15 2013 +0100
No need to delete the actions
they already have a parent
Reviewed by Martin Klapetek
commit 8ca79f41b8ba526f4e1bfc61169a278fa05956bb
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Mar 19 18:16:49 2013 +0100
Add a role to extend from
Reviwed by Martin Klapetek
commit 2609421040e0b7d5e94b66782ebf26accb1de344
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Mar 19 18:05:03 2013 +0100
fix compilation
commit b7f75bbf68f113f9433c1f184add650eaff6fb2a
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Mar 19 14:01:21 2013 +0100
Pass correct indexes to dataChanged()
Reviewed-by: David Edmundson
commit 5f08189f8a445279f2154b396cc1736aefcf4ffe
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Mar 19 13:49:47 2013 +0100
Make sure we're not appending empty data to the model
Reviewed-by: David Edmundson
commit baf37e7aad319b6c34851978a6295ef6640e1f07
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Mar 19 13:01:17 2013 +0100
Use correct include name
commit 8e1374c71fc8b48fbb720a549dec9ad1ce7d4148
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Mar 18 20:04:30 2013 +0100
Make examples and declarative compile again
Reviewed by Martin Klapetek
commit aaffe52f3fc88b0cb3c895911b8d46884359f358
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Mar 18 20:02:44 2013 +0100
Adapt PersonWidget to the new API
And admit that it's broken
Reviewed by Martin Klapetek
commit 10951e702b4a9010bfdb4dab37fffd61d4e1ebc3
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Mar 18 19:58:17 2013 +0100
Adapt to the new PersonActions and PersonsModel API
Trusted by Martin Klapetek
commit 47dc3a827fc37eec415733a8586af5f3d2010945
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Mar 18 19:57:25 2013 +0100
Make the duplicates test pass again
Reviewed by Martin Klapetek
commit 019a01ad123ca379ee3efb6f566f24cbdca35df5
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Mar 18 19:56:19 2013 +0100
Adjustments in the PersonActions API
Add the setPerson method
Add the actions() method for actions
Improve support for being used in QML
Reviewed by Martin Klapetek
commit dd9e51909c74c33668fc04b7ac23fc271a283eec
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Mar 18 19:51:58 2013 +0100
small fix in PersonItem
Whenever we ask for a role that is coming from the Contacts, if the data
is a list, put the items in the list, instead of providing a list of lists.
Reviewed by Martin Klapetek
commit a742ee3e7a754b8e0c960c0f13891812fcf7ae47
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Mar 18 19:50:07 2013 +0100
Remvoe unused role from PersonsModel
Reviewed by Martin Klapetek
commit 29ff00f22680c20cafd48565af070d4f2c65393b
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Mar 18 19:49:41 2013 +0100
fixes in the declarative plugin
let declarative compile again
add PersonsPresenceModel, since now it's needed
Reviewed by Martin Klapetek
commit afc326d847f6111a4eb72fb0ac8ad405a80a2b77
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Mar 18 19:30:08 2013 +0100
Small refactoring
Don't keep a member and a static variable holding the same data.
Centralize initialization by using setUri from the constructor.
Reviewed by Martin Klapetek
commit 8278c7df4edc884307140a3b4e831d2a19b4dfd9
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Mar 18 19:25:19 2013 +0100
Move the private members to a d-pointer
This way we can move the included files back in the .cpp file and we don't
expose the dependency.
Reviewed by Martin Klapetek
commit 2623cd8671d525caf60dc7066eb97d80e420e645
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Mar 18 19:41:47 2013 +0100
Recreate basic PersonActions for IM and Email
REVIEW: 109564
commit 52840e528720590414f2d617565db51c3325fe76
Author: Vishesh Handa <me at vhanda.in>
Date: Thu Mar 14 18:38:43 2013 +0530
Simplify the Nepomuk data extraction Code
Instead of using the Nepomuk property URIs as keys in ContactItem we now
use the roles instead. This simplifies the data extraction part from the
model as we can keep a direct mapping in the query (Binding Name => Role)
Additionally, the ContactItem class could also load the data on its own
by using the Nepomuk Resource class. It now uses the same query as the
PersonsModel and fetches all the data in one go. This is much faster and
simpler. Though, it results in a little bit of code duplication.
And finally, the ResourceWatcher now reloads the contacts which are
modified instead of just changing those specific properties. This is
done because in many cases such as - ImAccounts, Emails, Photos, and
ContactGroups, one needs to query the Nepomuk DB in order to fetch more
information.
REVIEW: 109481
commit 7fb61857cf881fabafda2c732c2ce9e08dda0690
Author: Vishesh Handa <me at vhanda.in>
Date: Thu Mar 14 16:12:03 2013 +0530
PersonsModel: Always fetch contacts which have im accounts
The PersonsModel is *for now* only going to be used in Telepathy, where
we only care about contacts with IMAccounts.
We could also just filter out the contacts which have an imAccount but
that results in us loading more contacts than required, and is a waste
of resources. The difference can be about 1000 vs 7000 contacts.
Reviewed By: Martin Klapetek
commit 6dd41a8efeac393594fccc26d766072fac1b62d6
Merge: cee6e1e 5f5f4f7
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Mar 14 11:42:50 2013 +0100
Merge branch 'mklapetek/toplevel_contacts'
Main development now moves to master, all code please through review!
CCMAIL: kde-telepathy at kde.org
commit 5f5f4f733eb7e1e61130db1a2c22792264188e57
Author: Vishesh Handa <me at vhanda.in>
Date: Thu Mar 14 15:50:08 2013 +0530
ContactItem: Also return IMRole for DisplayRole
It's better than showing "Unknown Person"
commit e5ef01360327b7e435608e3f5cc6b28c971b5d30
Author: Vishesh Handa <me at vhanda.in>
Date: Thu Mar 14 14:15:05 2013 +0530
Rename PersonsModelContactItem -> ContactItem & PersonsModelItem -> PersonItem
commit 741a3c7f4cd18d88de338a750e193cc71fdc8a0d
Author: Vishesh Handa <me at vhanda.in>
Date: Mon Mar 11 01:50:25 2013 +0530
Bump KDE_MIN_VERSION to 4.10.1
We need Nepomuk2::Resource::setWatchEnabled
commit f06fb16e8ae3aba6c9babda25c8c72eb09d36419
Author: Vishesh Handa <me at vhanda.in>
Date: Mon Mar 11 01:17:11 2013 +0530
Do not install the ontologies
This is already done by the telepathy-nepomuk-feeder. We cannot have 2
packages installing the same thing.
commit 569405b26074a35405945a7f05dbbeadf971501b
Author: Vishesh Handa <me at vhanda.in>
Date: Sun Mar 10 15:41:07 2013 +0530
PersonsModelItem: Optimize ContactGroupsRole
Avoid calling queryChildrenForRoleList twice
commit 3fce185f09ee711cfd3a5b04e7ab4e5301f866d8
Author: Vishesh Handa <me at vhanda.in>
Date: Sun Mar 10 15:36:15 2013 +0530
PersonsModel: Remove unused code for ContactActionsRole
The PersonsModel no longer supports ContactActions
commit 9de06963a243fe6b6fc09d1eb22a4dd1dc1bd52f
Author: Vishesh Handa <me at vhanda.in>
Date: Sun Mar 10 05:53:56 2013 +0530
PersonsModel: Remove the explicit check for nepomuk:/me
Add the check in the query instead. It should be faster this way. Though
the <nepomuk:/me> should never actually be a nco:PersonContact, so this
case should never happen.
We cannot do trick for the pimo groundingOccurrence as that is in an
optinal block and it results in the query results containing
<nepomuk:/me> as the groundingOccurrence being returned except with
?pimo_groundingOccurrence not being bound to anything!
commit 82d9408f204171f8d90a5a7e7633fdbfb0b614a4
Author: Vishesh Handa <me at vhanda.in>
Date: Sun Mar 10 05:13:34 2013 +0530
Port to NepomukCore properly
Do not link to kdelibs Nepomuk libraries. They are not used anywhere.
commit 148cb965b04af760843c1ac7922dcdba046d3fdb
Author: Vishesh Handa <me at vhanda.in>
Date: Sun Mar 10 05:07:00 2013 +0530
Throw away PersonActions and NepomukTpChannelDelegate
The code relied on the fact that the imCapabilities were stored in
Nepomuk. With the current version of the feeder that is clearly not the
case. Temporary data is no longer stored in Nepomuk. It is directly
queried from telepathy.
Also, disabled tests which no longer compile.
commit 7a9b1930187f02c3b24aac254f10d45c70be24fd
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Mar 3 16:56:46 2013 +0100
Remove ContactItem typing since nco:Contact can have multiple contacts
commit a781b049efde80aa31a9d88c1c78a13ec636b87b
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Mar 3 16:55:36 2013 +0100
Use async query; reinstates d-pointer
commit 871cc5015ac85e43522255ff6b70c94562d0c1e1
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Mar 3 16:51:38 2013 +0100
Allow storing multiple contacts for contact item
Since nco:PersonContact can have multiple emails, phones etc.
we need to store all of them and then return a list
commit 80fdfea452d2eb08e3ceeecde0634b9ccf6318e3
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Mar 3 16:48:30 2013 +0100
Register Tp types so we don't crash on startup
commit cee6e1e7dacd4eceb1bbfcd7f0df088d67f98479
Author: Andrea Scarpino <andrea at archlinux.org>
Date: Tue Feb 26 15:48:20 2013 +0059
Fix build (missing include)
commit 245ebed7be510db80f17a9e52ffdd85549b51731
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Feb 26 10:26:28 2013 +0100
Some optimizations
commit 42453c7f539d69064d861beb46d51800e0bd11b9
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Feb 26 10:26:06 2013 +0100
Handle contact capabilities properly; makes CL context menu work again
commit d2541c6862266e44e2ecedee3b76c0e0cb55f93f
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Feb 21 13:25:09 2013 +0100
Remove some commented-out bits
commit 1ff30b37a565099f6c95153294a85633fbf28265
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Feb 21 13:23:56 2013 +0100
Microoptimization - query for stuff only when really needed
commit 98969e9f7eaa7bfb9fd01730c1529b3993a4d9be
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Feb 21 13:23:32 2013 +0100
Don't emit dataChanged for each contact with the initial presences fetch
Speed++
commit 4b664f68c9c437899ab39ef4b763992cfb364748
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Feb 21 13:22:43 2013 +0100
If the account is offline, query Nepomuk for it's id
When the account is offline, our KTp::Contacts are invalidated
and so we cannot get Tp::AccountPtr from KTp::Contact. Nepomuk stores
the account id, so we can get the id and from GlobalContactManager
then get the proper Tp::AccountPtr. This gives valid account
even for offline contacts.
commit f56c698b41dc6a46640359fac48dabd1320e0f67
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Feb 21 11:33:36 2013 +0100
Heavy simplification of PersonsPresenceModel
commit 8b64fa6169e4d576924e8fdb7301d4ae8ce9f8c9
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Feb 21 11:14:30 2013 +0100
Remove comment as it's rather useless in light with the just-pushed optimizations
commit f2081fb22b4674afa7b0ed477c4c289d9568a038
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Feb 21 11:12:57 2013 +0100
Micro-optimizations in the translation proxy
Reviewed-by: D. Edmundson & D. Vratil
commit 503a7d15b0d274e3c063217bd8ff73f2bc708494
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Feb 20 22:59:43 2013 +0100
Invalidate the KTp::Contacts when we go offline
commit bdef11fb6affaf41995fc4e221f15f1ef8b4a1ed
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Feb 20 22:59:05 2013 +0100
Separate KTp::IdRole in the translation proxy
commit 62edd6ae5981dddae54dd1d41c9734f10bfebffe
Author: Vishesh Handa <me at vhanda.in>
Date: Wed Feb 20 14:21:18 2013 +0530
Minor Optimizations in PersonData
* Do not use inference in the query - not required
* Use operator [int] instead of [string]
commit bcd39ad34c9c6a18c009e02c395b554eee9334d9
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Feb 20 10:18:45 2013 +0100
Don't build Telepathy channel delegate, it's deprecated for now
commit bf5f0b78e818287d60fbe4d44f20189b1a3d6055
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Feb 20 10:15:08 2013 +0100
Comment out dpointer for now, currently not needed
commit 22826682321ed23a515c51985b8181d7485e33b6
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Feb 20 10:14:32 2013 +0100
Remove the Telepathy channel delegate from PersonsModel
This should now become part of PersonsPresenceModel
commit d3622eb8666de7502778aaa3d3d15135d1546ffe
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Feb 19 20:35:55 2013 +0100
Add missing return (d'oh)
commit 5d22bbb72d6b8ebc07033997abd8762d2fa439a6
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Feb 19 19:09:06 2013 +0100
Make PersonsPresenceModel usable even with no sourceModel
commit df413fcca02d4b61b25bde5c3433fb3e3d3b6a18
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Feb 19 19:08:42 2013 +0100
Disable PersonActions for now, needs to be reworked
commit afe4a080ab00a5690cd47cd70b1364f033173f4a
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Feb 19 19:07:46 2013 +0100
Rework PersonData to not use the model but Nepomuk2::Resource rather
We can query the resource directly via Resource with nice API,
so there's no need to invoke the whole model. This way we can
pass just any contact uri and through PersonData API we'll get
all the properties we want.
commit 0e9cd201fd856a043697269e7150728fe5e45dd9
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Feb 18 17:07:42 2013 +0100
Add BlockedRole to PersonsModel roles
commit e70a287355f9b818aeeb0b56a412544c98777ef9
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Feb 10 01:03:37 2013 +0100
Codestyle++
commit 97f496ad2e9f78d723ad54d2d414165699a9f920
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Feb 10 01:03:13 2013 +0100
Don't set the default contact type to MobilePhone
commit 242cc916aa1b6cfc4b4e539a8dd078f1fc7cd164
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Feb 10 01:02:44 2013 +0100
Use KTp::ContactPtr instead of Tp::ContactPtr
commit 89302aff335b3f9dcb4d3b315118e80bc8325f8c
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Feb 10 01:02:10 2013 +0100
Smarter checking for real property modification
commit fdba359741e573802820a475d067d1b2ed547fc7
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Feb 10 00:58:40 2013 +0100
Special handling for nco:photo and nco:hasIMAccount in contactPropertyAdded
If we get new avatar feeded, it's in a subresource nco:photo, which
we need to query for the actual url. Likewise if we have new nco:IMAccount
added, we want all its properties immediately available in the model,
so we process it with pullResourceProperties(..).
commit dae943a0f5fcc16696c92c5d779791667a3d04f7
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Sun Feb 10 00:56:40 2013 +0100
Simplify the IMAccount watcher, basically we're watching only imNickname change
commit cc558da0b11db9aa92a1608c1e3a262297c0f186
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Feb 7 19:25:54 2013 +0100
Optimize looking for the contact in the hash
commit 01ffd1f590717115ec53c73e06fd650a372f703b
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Feb 7 19:25:35 2013 +0100
Emit dataChanged() also when the contacts get removed
commit ce71c6a1cbea86ebaa81baaffec79e6dee6f77fc
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Feb 7 19:25:05 2013 +0100
Emit dataChanged() even for parent node (which does not seem to be happening)
commit 73d8c62a8880e5775f015e2b74b7a89d34b12e56
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Feb 7 19:24:44 2013 +0100
Rename m_presences to m_contacts and use KTp::ContactPtr
This might be a performance hit, need to watch for this
commit fb4003e0e0df01ed0a09a353ab3f3609396dd149
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Feb 7 19:22:12 2013 +0100
Port to the new KTp model roles
commit 6b12ef9b8382d400a48ad928880781e6789d91e3
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jan 30 17:53:26 2013 +0100
Forgot to commit the header function
commit 53de54d0050b136000d026fc9210ab809d24e528
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jan 30 17:52:53 2013 +0100
Return Tp::Account & Tp::Contact in the presence model too
commit 3621b307f02b337ee1db9e460f54b641bfe4fc00
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jan 30 17:52:19 2013 +0100
Split out the queryChildrenForData into its own function
commit ddac0984f822d9aa5d6b0b0f2ef6ec3eec3c07b1
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jan 30 17:51:41 2013 +0100
Return "offline" presence before we have presences ready
commit 6576194b54f5be6fe1e13b4fbcc36a8b45b02029
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jan 30 17:50:17 2013 +0100
Add IMAccountRole & IMContactRole to the main KPeople roles
commit 428b3eb420decf62a3033293e3b183a78c44df63
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jan 30 17:49:16 2013 +0100
Add more roles to the translation proxy
commit 5eb235ee75e1ba801bf5d570d61f023ab8392605
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Jan 24 16:43:01 2013 +0100
Use GlobalContactManager in PersonsPresenceModel, support Person contacts too
commit 07206c5468a6dfb5d3fc3f1ad665c0775af153dd
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Jan 24 16:41:43 2013 +0100
Remove useless debug
commit 105371f662c5d2cc9742ce8ab42e142756f69244
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Jan 24 14:36:26 2013 +0100
Disable querying for Telepathy stuff in the main query for now
commit de9122f1ea8ed0be240293dbc6206c48821bf415
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Jan 24 14:35:48 2013 +0100
Add groups support in the translation proxy
commit 23934ec4af7945a5f776ea779292ee4e8f4e4bd6
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Jan 24 14:35:29 2013 +0100
Add contact groups to PersonsModel
commit dfe93d17b2bf09596bd99aad77e657a3a89a2cde
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jan 23 00:56:22 2013 +0100
Make PersonsPresenceModel friend with PersonsModel to access private stuff
commit 265aad37b3623c29af60942993b841f1d0396796
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jan 23 00:55:35 2013 +0100
Build PersonsPresenceModel & KTpTranslationProxy, install headers
commit 673878a9548f0e1835ae58d74d636956f7fee115
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jan 23 00:55:13 2013 +0100
Don't query for presence in PersonsModel and always return "unknown" presence
commit f63a82da97165e4bdca7de96cf8c54cccb2ded7c
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jan 23 00:51:30 2013 +0100
Add simple proof-of-concept translation proxy between KTp and KPeople models
This translates the roles from KTp models into KPeople roles, making
usage of existing KTp infrastracture (proxy filters, delegates etc.)
very easy.
commit 34ff1153ed20b9100e6df4cb9dd80dffca5ff35b
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jan 23 00:49:08 2013 +0100
First draft of proxy model adding Telepathy presences
The idea is to provide presence and capabilities information directly
from Telepathy, which gives us instant changes and one less layer
for the data to go through and even easing the Nepomuk load. This
is done in a proxy model, so if we don't need the real-time presence
updates, we can use the PersonsModel directly.
commit 8c0da6f4f47b59db8df379cff176b8540762203d
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Jan 17 21:46:24 2013 +0100
Fix launchpad build
commit f7ed82ab4dc28c4c763666b520317740a7b0f683
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jan 14 09:44:52 2013 +0100
Allow searching in existing actions by contact
This comes handy especially in the address book where the contacts
are displayed as strings (for example email addresses), with this
we can also get the proper QAction for that string and therefore
enable the interface to start actions on each contact (including IM).
commit 2648872d348bee5fe821b24b926991cdec2c3825
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jan 14 09:36:07 2013 +0100
Unify action property names for getting contact
This will allow to query the PersonActions for a particular contact
and get its action, comes in next commit.
commit 64db97e95ffe3fa98347e37af8598efd32211b1a
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Jan 14 09:11:15 2013 +0100
Add new method for creating pimo:Person from indexes
This moves the logic from the application side to the model
itself and thus simplifies the code there.
commit aa7385dfe992cc434d797854c9143c3c48e6ea5c
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Dec 11 22:59:20 2012 -0800
Clean the query results processing and add comments
This could still use optimizations though, loading ~1000 contacts
takes now roughly 3 seconds, which is not bad, but still too much.
Might be worthy doing this in a non-blocking thread and adding
the contacts to the model continuously. That would result in immediate
GUI visibility and also visible indication of data loading.
commit c05cc1ca840d38864058414da852a08332a70714
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Dec 11 21:46:17 2012 -0800
Fix build & polish
commit c17f567012a78e9d59f464f2cb98b17fa1f7e55a
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Dec 11 21:44:07 2012 -0800
Check the item before using it, crashes--
commit b46f43a14dc748090b7f638a8522c4d97a88e7a3
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Dec 11 21:43:24 2012 -0800
Proper contacts reparenting when removing pimo:Person
commit 33f3074a84f236574632f7f9efe253ba833bb626
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Dec 11 21:42:55 2012 -0800
Add all contacts to person at once instead of running jobs for every contact
commit 343ce4cc99d16aff1481ce7629ab3b3053075ab7
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Dec 11 21:41:48 2012 -0800
Add method to remove contacts from pimo:Person
commit 0ebba1ba8271e4314b9e6c639ca76d4dbbdcba77
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Dec 11 21:40:21 2012 -0800
Proper handling of removed contacts in the watcher
commit 5f3236e43095a6f791a7779d6861588641a87b91
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Dec 11 21:33:09 2012 -0800
Check the "added" argument as well in propertyModified slots
If either "added" or "removed" is empty, it means the property
was either removed or added, but not changed. In that case
it is handled by the corresponding propertyAdded/propertyRemoved
slots.
commit afd3cc073c1e0baebb76ca722f929ce804a9beb6
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Dec 10 19:45:01 2012 -0800
Random small fixes and polish
commit 004aca7daef6f3f6e3761b276dbf4114afbea5bd
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Dec 10 19:43:49 2012 -0800
PersonData API changes:
* Add accessor for name
* Change contacts -> bareContacts
- This simply returns the contacts without any info what they are
or any possible actions on them - bare contacts. For contacts
I have a different idea.
* Accessor for determining if the item is person or not
commit a58da037f456c5628e26455adb022a52c53806ef
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Dec 10 19:35:44 2012 -0800
Return only one photo from children contacts
commit 43082fe15bd877a793124d5bc10ed4e2698d8edd
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Dec 10 19:35:14 2012 -0800
Fall-through more roles
commit 06489670d55f511b2252c35a44fc023384408cf3
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Dec 10 19:34:11 2012 -0800
If the child items have no actual data to return, return just empty QVariant
This prevents situations when we return QVariant(QVariantList()),
which makes the QVariant non-empty and thus failing testing for
data presence. This simply returns empty QVariant if there is
nothing to return.
commit a39a925aec3a46dde71dc622cd0b19d5fd8fac8e
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Dec 10 19:31:37 2012 -0800
Add the nco:PhoneNumber property to the list of selected properties
commit 9f28120c1b336649a90a7202cf1fb43297c33915
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Dec 10 19:30:59 2012 -0800
Method for adding nco:Contact into existing pimo:Person
The contacts are reparented automatically in the model
thanks to the resource watcher signals
commit 1e98f2a481a21ff28ec9130e3c00aa0c3a98c04b
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Dec 10 19:27:48 2012 -0800
Change PersonData::nickname -> PersonData::imNickname
It actually returns the IM nickname, not the contact's nickname
(that's different property)
commit 725bb4ddf1ed844431afc5bc631dc62cc4279fe3
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Dec 10 19:26:31 2012 -0800
Query the contact for "contactId" if created from uri
commit 03a2e3d92291fe86c7ae34b033457012a450a7e9
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Dec 10 19:25:05 2012 -0800
PersonData queried improvements:
* Put the email address among selected properties
* Optionally check for nao:prefLabel
* Optionally select nco:phoneNumber when querying by uri
* Replace "..."^^xsd:string with <...> notation
commit 18eaadb165698f75184400f6c37b95f7f219bb08
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Dec 10 19:21:50 2012 -0800
If the channel starting method was called with empty capability, return
commit 035e29c7d1bf74359cbdbbb3fe20a760d0580fad
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Dec 10 19:21:25 2012 -0800
Basic error handling in the channel delegate
commit 5b63e5003bf61942878e7faa0b6d8bc736afaf0f
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Dec 10 19:20:23 2012 -0800
Add IMAccountTypeRole for getting account type
This allows for setting account icons and display more
friendly account names like "Facebook Chat" or "GTalk"
commit 99051e5ea7714146908975a88932ae018d0a59ff
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Mon Dec 10 19:18:07 2012 -0800
Don't try modifying contacts with invalid model index, prevents crashing
commit 6709117d242acaf4bf451cb734f8b1353053f31d
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Nov 16 20:40:09 2012 +0100
Null the stored actions when capabilities change
commit 56945f7b95da3ff6cd03144a00d6f8734fa1dbf5
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Nov 16 20:39:14 2012 +0100
Set icons to IM actions and use same string as in KTp Contact List
commit 74f0c40eac221ee2a50dbb291b8b61ddf3705f54
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Nov 16 13:48:17 2012 +0100
More Coding style++ (these files somehow got out of the prev commit)
commit d3d4d5a5bd1a64a748e64eb0f1a34971b47dace1
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Nov 16 13:44:41 2012 +0100
Store the PersonActions object rather than the list of the actions
commit cbb6398fa2d58c6b1eb20c2faccc5f8a50fccd70
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Nov 16 13:44:03 2012 +0100
Coding style++ (following kdelibs coding style)
commit 1337fb239df5e7fc5f49ea9f758f5539ea7c89aa
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Nov 16 13:03:26 2012 +0100
Add a code comment
commit a5cfdf8a325097be9e3122e95cb40cf0d8f215ed
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Nov 16 13:02:30 2012 +0100
The PIMO:Person cannot be contact itself, so query the children for contact type
commit 0317e37253d558a8222f52e862a98b5bcbe149e4
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Nov 16 13:01:52 2012 +0100
qDebug -> kDebug
commit b2e4ddcbd153c9e526bb9a44e6ca02288a0c26f2
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Nov 16 13:01:27 2012 +0100
Don't split the PIMO:Person on unmerge into two new ones, for now
commit 472af087b0bd813755c088c3412d51938130294f
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Nov 16 12:59:59 2012 +0100
ContactsCount -> ContactsCountRole
commit 7d4195793d510229c12883a0622f6ac7fe6051a3
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Nov 14 00:07:19 2012 +0100
Handle contacts and persons properly
commit 60d45ea754d495f1c4e5c0e414484583493bbc83
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Nov 14 00:05:19 2012 +0100
Add nao:prefLabel to the query and contact objects
commit 74a429a130f7ea3e0a093aa9577f2b946d686431
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Nov 14 00:03:19 2012 +0100
Create new contacts in the model from resource watcher
commit e7f7923769d1be415711c0a8f2182fc72d969454
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Nov 14 00:01:06 2012 +0100
Code polish, whitespace cleanup, #includes sorting
commit 2be62485ce265256c5400a16ecc6bb460e679ff8
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Nov 13 22:50:06 2012 +0100
Allow setting up PersonData with uri too
commit 01b84782a85d5de1a9cf08c055acfec3ca5c7c6b
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Nov 13 22:49:07 2012 +0100
Add resource uri as a PersonsModelContactItem class property
commit 876d70ed24e30ac82f6b7c3d1b51fae0fa64ba96
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Nov 13 22:46:34 2012 +0100
Add PersonActions as a role in the model so it can be accessed directly
commit be4442700a45d3061c0d0fd7e7ab9a3cf3f6de55
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Nov 13 22:40:18 2012 +0100
Don't add nepomuk:/me PIMO:Person to the model
commit 34cafe2a5681c24a9ebe9dc09ee292bf783a86f5
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Nov 13 22:38:39 2012 +0100
Add the ResourceTypRole into the roleNames() of the model
commit 914d8cd01f4e6f58c2a9573045d71923abe38b4a
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Nov 13 20:05:41 2012 +0100
Move the Telepathy channel delegate to the model
We need to initialize Tp::AccountManager asap, so when we create
the actions, we can start a chat right away and don't have to wait
for AM to become ready.
commit b7e25e6bf83fbb1fa797742c516ebdfd4db71f37
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Nov 13 20:00:33 2012 +0100
Swear a little bit less
commit f20bb7c8ba7ec1dbc866d7645f742a27e91819e0
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Sep 28 15:56:14 2012 +0200
Reparent model contacts under the newly created person object
commit 49b663b4e703af620b4b52a90e2cfca86724b258
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Sep 28 15:55:22 2012 +0200
Pass only the person uri as that will not add the contacts from groundingOccurrence
Rationale: if we're adding contacts to the person, we need to check the model
if those contacts are not already in the model and if they are,
we need to remove them from the toplevel and put them only under
the person item. In the time of creation, the model() call from
PersonsModelItem is null, so we cannot check the model.
Furthermore this slot is used only when new pimo:Person is created
in Nepomuk and in that case Nepomuk *always* signals propertyAdded
with "groundingOccurrence", so we get the contacts either way.
commit a8601788d39611397406eb50d10f752ce52e4d7e
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Sep 28 15:53:52 2012 +0200
If the old person has no more contacts, remove it
commit 46e525760f0695af797ac243b5d7cedefba467ae
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Sep 28 15:53:16 2012 +0200
Provide a method for grouping the contacts together
This takes QList<uri> of nco:Contacts, creates a pimo:Person
and adds the contacts as groundingOccurences.
Removing person is done by removing pimo:Person from Nepomuk,
which will be signalled by our resource watcher, which will
remove it from the model as well. The contacts stay intact
in both Nepomuk and model.
commit 1e6f8017dbad9a4d0256534fffa7e5757c4c8702
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Sep 28 15:50:04 2012 +0200
Provide a ResourceTypeRole to know what we're dealing with
commit 9be566faa0c43844ef2a50a0ed91bb3ed417eaa2
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Fri Sep 28 15:49:05 2012 +0200
We need to move the contacts to toplevel when person is removed
commit 8bb5921236a55de25130e960a3bba7a7990830ed
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Sep 27 15:38:35 2012 +0200
More whitespace fixes
commit 9684aea77a2569088e7364e1506aa35b7231bbe6
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Sep 27 15:37:20 2012 +0200
Add method for changing IMAccount properties, like presence/status
commit 48e1ef04527d28d1e7a53b4045ad039b71e38ba8
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Sep 27 15:34:15 2012 +0200
Don't automatically create the contacts with new persons
If the person was really newly created, we'll get the contacts
signalled in propertyAdded(..) signals, if not, then we shouldn't
be in this slot in the first place.
commit 6e6aef10e25876aee357550716caa3422fd54236
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Sep 27 15:29:20 2012 +0200
In the propertyChanged(..) slots do nothing if removed() is empty
That means that the property was added and as such it will be
handled by the onPropertyAdded(..) slots
commit 8d2dca6b304924a53a6f5c74ff3a6b58d6f24d28
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Sep 27 15:27:39 2012 +0200
Don't create a person if we get a propertyAdded signal for invalid person
Nepomuk has been patched to always emit resourceCreated() first
so if we get a propertyAdded signal for non-existant person,
something's wrong as the person should always be in the model.
commit daf9efc29a265c3e3216c9b728ae6c64e2b218da
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Sep 27 15:24:08 2012 +0200
Fix whitespace, so kate/kdevelop does not keep going crazy upon close
commit e4926e81b7b1287d9abe48dba6fca22c80c86151
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Sep 27 15:21:38 2012 +0200
If the NickRole is empty, return email, if empty, phone. More might be needed.
commit e57b5268dea12777350577664fd8795018c49dd6
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Sep 27 15:20:50 2012 +0200
Allow passing a single property value to modifyData(..)
For example when the presence is changed, we need to replace it
with just one value, not a list of values with one value in it
commit 86760e7f28deed6149614871fe776a7e3a5b3b89
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Sep 27 15:18:21 2012 +0200
Do nothing if the passed contacts list is empty
commit 1d78289c0683bc7c54cb0bd73dac401d854ad98c
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Sep 27 15:18:00 2012 +0200
We need to be removing the known contacts, not the new ones
commit 13f18b143e84b3a0f899ca5712fbaa55ba68308d
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Sep 27 15:17:15 2012 +0200
Append the standalone contacts to the root item directly
commit 4521e88b994cfdb7bbc661d066b0479ec2658cf1
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Sep 27 15:15:54 2012 +0200
Make the grounding occurance optional -> query primarily for contacts
This will return us all nco:PersonContacts, so we can display
all the contacts and optionally group them if they have some
pimo:person above them, otherwise leave them alone.
commit 5eb303a70f5aab08feb8df71217379131f39f882
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Sep 20 18:30:33 2012 +0200
Also install PersonActions
commit 89c5f06438bfdbaf3b6ed44eff511e48c9d7b5cf
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Sep 20 16:44:04 2012 +0200
Install all the public header files
commit 971de53fa1d532ee398538784bbe65002709eef4
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Sep 20 16:43:40 2012 +0200
Install a FindKPeople.cmake file
commit b01ca7dd9d9b779712322ea9e22b167001b58e2b
Merge: 7ec2833 ad2d1b8
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Sep 20 16:02:59 2012 +0200
Merge branch 'apol/queries'
Conflicts:
src/person-cache.cpp
commit ad2d1b89f5dcc7bae0a08c89fc3e031cffe099df
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Sep 20 13:51:45 2012 +0200
Improve PersonData interface
Specify further Q_PROPERTYes for eventual access from QtQuick.
Add some documentation in the methods that need it.
Make sure we'll notify data changes.
commit 5c2cc6d273aad42909127962e2489984134ca653
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Sep 20 13:42:40 2012 +0200
Actually only fetch the person we're looking for in PersonData
commit 19773096213a5621c0b355b881ece5b98de4987e
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Sep 20 13:42:16 2012 +0200
make it possible to fetch the contacts from the PersonData
commit 6a083e2eceb2186450ea7f7b88ffbd8afff7e218
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Sep 20 13:41:30 2012 +0200
Adapt nice persons to the new PersonData infrastructure
Now it should wait until the data is fetched from nepomuk to set up the
interface
commit 81f16bc5a3f8d0fbd676b449039b27a512b9a05a
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 19 18:10:29 2012 +0200
Fix some issues that appeared while porting to the new PersonData impl.
Now the problem we'll have is that it's a tad slow, but I hope we'll figure
this one out :D
commit 00cfa44dd31f37c0ae91de121bddf92fcae85c4b
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 19 17:54:53 2012 +0200
Re-implement the PersonData in terms of a PersonsModel
It's good because this way we can re-use the updating logics of the
PersonsModel.
commit c92784f1ebc127e300f62b7368c237ebde566ce1
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 19 17:52:57 2012 +0200
Make it possible to query the status from the persons model
commit 325765468497194f8b5c79c48769fc5dc20d0577
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 19 13:15:24 2012 +0200
Create a new PersonData test
commit c1d9dd90bec50082233e4d6f4008ac59014cd7cc
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Sep 17 16:29:19 2012 +0200
verbosity in a test
commit c4e7fb044d99005064805cb0018bfe9098afa525
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Sep 17 16:14:09 2012 +0200
typo!
commit 797ada01500cd7d0299173b1e0d3bf9e7425f2cb
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Sep 17 16:06:58 2012 +0200
don't benchmark photo extraction
right now it's not extracted on request, so this is fast...
commit 27025c1fc87fb4ec90ef641d2df86bf4b3ac12b1
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Sep 17 16:06:27 2012 +0200
make tests id's unique
commit 1f520004131af3e05da45eb80b0dce0eac1b6055
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Sep 17 16:03:26 2012 +0200
what defines a contact for being email is having an email
makes some tests to pass...
commit c6a92a71aac6d2c9bfc3eb6a6d01ec960b335ef5
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 14 18:38:10 2012 +0200
expose the actions in the niceperson example
commit c82af8332f3b6e6b68432a9b155420abade7f149
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 14 18:37:51 2012 +0200
remove unneeded braces
commit 1cf8df18cf2233b57ff05c5400b2c1d86a8d2335
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 14 18:32:19 2012 +0200
Don't check and remove, just remove
commit f59da56c3cc1ecdf54e6d63388b8cb6446d5cb71
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 14 18:31:58 2012 +0200
Make it possible to provide actions for a PersonData instance
commit 69f7c850a37b5824faccfd24b17f384feb43472c
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 14 17:09:49 2012 +0200
fix ugly include
commit afe058a07e0614967af34816c781e950c66c4b45
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 14 17:09:40 2012 +0200
Properly retrieve a contact for its IMAccount URI
commit d2a6e863971c40991de8762f8a8f2f71865694a3
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 14 17:00:02 2012 +0200
Created niceperson
It's an example for displaying a said person: That is, just a GUI for
PersonData.
commit 587ff6c4274b1325deccfd349f850410fb0a2d15
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 14 15:59:19 2012 +0200
make sorting case-insensitive in sweetpeople
commit b0e88239b6dc58f120c9eec4edb73d5fdb80b9cd
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 14 15:58:56 2012 +0200
put the url to item variables together
commit 03a9d9d7269e1f93b3f3708adb02368e2608e3f2
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 14 15:58:34 2012 +0200
First approach to a PersonData class
This class will provide the data for a single person instance.
commit fae00a680dcf42afd8b1a7aec3637ccfcce88b12
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 14 11:53:44 2012 +0200
Properly feed/extract the photo from the contact
This fixes the extraction of the photo when pulling from a resource (like
when updating after a change)
commit 76f6c1b71ae820ecbfeffeb416a6e2f22cc74473
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 12 20:38:12 2012 +0200
Update the IMAccount when it changes
commit f57aae290b33cd865ca83993266771ba265e0a37
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 12 19:44:33 2012 +0200
First approach to an actually working watcher service
commit 7f8b65b796aaa1b4ce0e22539b26836872946cce
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 12 18:36:39 2012 +0200
Big push to the resource watcher, to be able to react to changes
let there be bugs...
commit 090fa546219b9dfd41fc84ab8fa19c514a0bdce2
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 12 13:40:50 2012 +0200
Reorganize the way we provide the display in the model
It will be the nickname, only the person will fallback to the contact id's.
Otherwise it can happen that the person fallbacks to a contact id while a
different contact has a nickname, which would be preferred.
commit 484d6c634a0f5966c4e42ee4c2da9c8ef46474e6
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 12 13:38:24 2012 +0200
Improve feedback after running duplicates
commit 51ab54b9813fa05fb3a61e7cb7f018bdd17ae8ce
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 12 13:16:23 2012 +0200
Improve the duplicates example
- Improve the way we report matches, add more information
- Fix the way we handle if we're applying or just asking. Until now they
were swapped and it was a mess
commit 8f7f06e22b70cc2c222c6b9f2a42727e0cd8095d
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 12 13:14:55 2012 +0200
Improve the duplicates finder regarding lists
commit d5d503c5bac82f2c12527b90167c22e21116b813
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 7 16:58:22 2012 +0200
Small changes related to contacts
Simplify initialization
Set the default type to phone. It's more rare so it helps debugging.
commit d844b86375dfba486f5893fdecf84a961610421b
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 7 16:57:05 2012 +0200
Unify naming of groundingOccurrence
commit e06f313d601a52c5003288b8b987455cc70345b6
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Sep 7 14:07:03 2012 +0200
extended the person actions
makes it possible to start the audio and video capabilities
commit 58923854d8b2c7e1d99d17e23170a1bc9590945c
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 5 18:42:08 2012 +0200
Provide the actions for all the capabilities in IM
commit e25a2d194e84c6248ea45adf066b0e364f84f129
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 5 17:32:19 2012 +0200
remove warning
commit 0a2076a2ddfd9763bee857b60b5ece20f2de5209
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 5 17:05:02 2012 +0200
don't compare values if the index is invalid
commit d4e5775d2adb3f7d60709c0951def55889794b6b
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 5 17:02:35 2012 +0200
Gather the capabilities when bootstraping the model as well
commit 34db533062960bb97b9ca5c7795f57e8e47f48c7
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 5 16:40:28 2012 +0200
Slightly improve the photo extraction...
... by putting the info back to the initial contacts query.
It's not really where I'd like to go but at least it doesn't freeze the UI.
commit 2405c4168d1522917ef950349dc2de1d9f912565
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Sep 5 16:33:41 2012 +0200
sweetpeople: clear the merge items after merging
commit 007c00b780f678ea727e60e88bf4ff5f0239c573
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Sep 4 01:30:47 2012 +0200
Adapt to changes at the components in kde-runtime
commit 228f6e3227bd9fa9b79af9d99338c213f13ec073
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Sep 3 17:29:27 2012 +0200
fix linking of sweetpeople
link against kdecore
remove KDeclarative_FOUND conditional
commit 1f34aeb77074ed724828da3feaf713f85ee357e2
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Sep 3 16:37:20 2012 +0200
Improve sweetpeople usability a bit
commit 0bb6da6ebf2de2a2cffd735d82c65756c4a45506
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Sep 3 16:36:58 2012 +0200
Prepare the resource watcher for better watching
Although it's not really working... :/
commit d7375303b3ab469273d9d28ea9d07e4a10460eac
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Sep 3 16:26:53 2012 +0200
Make sweetpeople a KApplication
Solves some runtime warnings due to the uninitialized KApplication
commit 74ae1bc5f6e788be062b8e5687864c3bd0224554
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Sep 3 16:04:07 2012 +0200
Properly implement indexForUri
commit 4c6d5ab44dda3984bb4eceb98437cb29db6d9461
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Sep 3 14:36:45 2012 +0200
Port the watcher to nepomuk2
commit 4bfd6f1e3d4fe16e70f8522421fa32b09d123909
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Sep 3 14:36:18 2012 +0200
Add some GUI for merge on sweetpeople
commit 980db6d1d22dd557299a30d3a8887e810eb0304b
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Sep 3 14:36:01 2012 +0200
Add API for merge
commit cc50b13064470f6721d0eb1c90be3af56cf87fb6
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 17:39:36 2012 +0200
Put the resource watcher into work
Doesn't do much yet, but at least I got to see some reacting to changes :)
commit 987a03ade118643a4bd03de901149e2cc5e2d132
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 17:35:24 2012 +0200
sort the sweetpeople
commit 1f7fae0b44ee3184e679f184cbd881148de68bd7
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 17:31:05 2012 +0200
Improve sweetpeople
clipping and better drawing of the images
commit a46c085e1dbc150041ee70461ac33dacd24c1da4
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 17:17:42 2012 +0200
Improve duplicates lookup
Don't consider two QVariantList() values a match
commit 0304b81df98f6d77e6668fc7baf934ede30d3c42
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 17:11:03 2012 +0200
Don't try to solve the person-less contacts problem in the model layout
Only search for contacts with a groundingOccurence, we can upgrade them
to people, if they deserve so at a different moment.
commit 04c67669271f500828e4c53e54a11315b1ccd829
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 16:54:11 2012 +0200
Changed Nepomuk/ includes to Nepomuk2/
Sometimes I needed Nepomuk2/ and they can't be mixed.
commit 0d6a5178a9a4ff8ad9a343e46b627fd3c3333149
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 16:45:55 2012 +0200
Make the watcher compile again
commit f2ad68eaf6a77cd288ed833921156c81018b1611
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 16:45:34 2012 +0200
Remove the PersonCache
And put the funcitonality in the PersonsModel.
They had this 1:1 dependency, so it didn't make much sense.
commit ebcc71b467846dd3c67c8d02e066de51de8bd833
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 15:47:16 2012 +0200
Don't display unmerge if a person has one or less contacts
commit 0efdb4838d43ab0a9ceb7a8a30c988a5e6724141
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 15:46:43 2012 +0200
Expose on the PersonsModel the number of contacts a person holds
commit 85590924efb96ee01a962a59c9020a9a6d39dd6c
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 15:40:45 2012 +0200
Make it possible to provide all person's contact id's
commit 6230e1003dc04b643e377bf79dccf293797bcd06
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 15:40:00 2012 +0200
Fix unmerge
commit a7caffcb948489fcd73b1fde6441a00eeeaa3738
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 13:20:03 2012 +0200
fix compilation
commit 73aa2a3469b401ecfcee16684cf3aa797188c17d
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 13:19:43 2012 +0200
Add unmerge interface in sweetpeople
commit 003ce3ede6f5bfaa368f2b518c92b1d706c50f13
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 12:51:29 2012 +0200
Implement the ContactIdRole for contacts
commit e7ad2e6e91ebd7fcb7a693caf71a94e6b008e8a1
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 31 12:50:23 2012 +0200
Make it possible to unmerge a contact from its person
It creates another person with the contact alone.
commit 43a56120e8f0017a12c9a86e4c6521a825dbe513
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 28 19:40:12 2012 +0200
Improve the detection of non IM contacts
commit 2fab84447c482e07ed13e62e53449fe4d795b943
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 28 19:39:17 2012 +0200
Make it possible to filter the sweetpeople example
commit 589cd7ac9c25eb33d3e191b098f6e764bce1c7f6
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 28 19:37:07 2012 +0200
reorganize sweetpeople information exposition
commit 208fdddee5e77ba915d27355c917950592e8406a
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 28 19:35:15 2012 +0200
add TODO
commit 72808c3d404a185d9bbdead4ccbc1486a6098028
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 28 19:35:07 2012 +0200
Better deal with non-IM contacts
commit 53e036be28a3ec19634f22469c817d2d2882fab7
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 28 18:18:49 2012 +0200
remove unneeded "distinct" from the query
shouldn't have been added, I was just trying things.
it makes the query finish >10% faster
commit c8c5d11aa7df6a9eacea4266e9d690702ff0638d
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 28 18:17:59 2012 +0200
add missing \n
commit 452baf68e3b23e535106a3ba17b7e8070a1a4f02
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 28 16:58:31 2012 +0200
Use a more interesting layout for the sweetpeople example
commit 8024779a9598480df0ee5c77c723c7654d7da404
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 28 16:58:11 2012 +0200
Don't insist in retrieving the photo of contacts that don't have
when the property changes the d->data entry should be cleared so that it
can be fetched when needed.
commit 724a430d769efb5f9e20388dd29057214335bfdf
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 28 16:54:15 2012 +0200
Reorganize the keyUri-to-bindings code
Puts static conversions to be only done once and cached for later usage.
Makes the algorithm slightly faster and the code easier to read.
commit 1556ffcef7cfe778630f2a78735c7ca922771fba
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 27 18:01:38 2012 +0200
Make the action name specific to the action type
Useful to differentiate between send email to ... at gmail.com and chat to...
commit 01ee1a76074c6e1556e273ae02003e5605747541
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 27 16:27:10 2012 +0200
Add a unit test for PersonActions
Every person should have its actions
commit 067a00fd6af9b578f8f934f8aa9930e07c3ef5a1
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 27 15:49:57 2012 +0200
Remove some information from the query that we're not using
Mostly the account identifier, that it's being queried on demand.
commit 5ca584fe3f0d4111971c95362c300a53b903f5f8
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 27 15:45:07 2012 +0200
Make it possible to start chats from PersonActions
commit e97493f641519fe143fa2024fd23127485c717f0
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 27 13:50:06 2012 +0200
Improve the throughput for photos extraction
commit ed61d000b5caecd4aafadab207edeb4c961a77d4
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 24 19:02:26 2012 +0200
Test the photos retrieval throughput
commit 2d7ec93a6fb89cf1d8f50de560412f9e146247ba
Merge: d3114b7 8c9f071
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 24 19:01:00 2012 +0200
Merge branch 'master' into apol/queries
commit d3114b7a5dbed065c20fe1554650533305ff0cf9
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 24 18:57:45 2012 +0200
Expose the photo role in the sweetpeople test app
It works!
commit 6d7ce9a19c02559a1b4d66d7f889686533bf7cf7
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 24 18:57:17 2012 +0200
Add a photo role and implement it
commit 81337315355b2678cafb2bb2c064f988fdd6995d
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 24 17:16:14 2012 +0200
Simplify cache initialization code
commit c6fd9b87efa1e4e602a4e3d4aef5bc79b3f7142b
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 24 17:15:52 2012 +0200
Don't query pimo stuff when looking for contacts
commit 7ec2833a62e294846b10db2900b58cb30f0847d0
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 24 17:07:42 2012 +0200
add information in the lovelypeople delegate
commit a96362a9001169e9d2ee124e8f4dd4caf2b4bc70
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 24 15:52:18 2012 +0200
Remove unneeded include
commit 8c9f0718876731b9ee7602809a63a1b92d18e779
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 24 14:34:57 2012 +0200
readability++
commit 56a4126c9bddbdd99f66be99301e20a8b9083ff7
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 24 14:34:41 2012 +0200
--debug
commit c8cf92ec62a2cfc0ad3e15ee9b940153de36aa14
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 24 14:34:17 2012 +0200
Test the PersonsModel
for the moment in only benchmarks the PersonsModel construction
commit 480ff4ab52a1a539ea4c4438ce9c4dec9eabb3d2
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 24 14:33:47 2012 +0200
Improve testability of the people model
by telling when the contacts have been fetched
commit 36ee245c0e8d32258c5465676541306c641411ed
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Aug 23 20:43:37 2012 +0200
Improve the sweetpeople example
Integrate actions
Improve error reporting
commit c012c1219be7b63051bc1f30607849fea05bdc7f
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Aug 23 20:42:30 2012 +0200
Add an object that displays the actions that a person offers
commit 3b513efd93cf1d47433dab5764ea7c9db22c6c3a
Author: Aleix Pol <aleixpol at kde.org>
Date: Thu Aug 23 15:51:02 2012 +0200
Don't store data if we're going to compute it anyway.
commit 8015c81ba2b535fbcfe141a6bc7656967e6e53e2
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Aug 22 20:31:50 2012 +0200
Improve the person data extraction
commit bb675cc4c3b6bb0ff51ef779639b463c3daebf48
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Aug 22 19:59:58 2012 +0200
Slightly improve readability
commit 06ccddef0504ca5b69df4e06201a058c2b7986b8
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Aug 22 19:59:25 2012 +0200
Improve Person introspection
Report all IM, Emails and Phones of a person from the model
commit 0f6e23d85ab51628b8e380a4130d5aa3fbf5f38e
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Aug 22 19:47:05 2012 +0200
Make sweet people to puke all the PersonsModel data
commit 9bb125928143e749ffd06081c96c4df4e1b7d503
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Aug 22 19:12:14 2012 +0200
Attempt to make the initialization a bit less blocking
commit 4ac2fe884245f308e38a053fe0ab4dec22cb9416
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Aug 22 19:11:59 2012 +0200
Provide some initial size to the view
Otherwise it's considered to be empty and nothing's shown
Also make it possible to resize
commit 9e6e3ef6289bdce96d24cf0487e893b7cad75f7b
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Aug 22 19:04:46 2012 +0200
Create an example to be able to test the qtquick KPeople plugin
commit 07c7683baef244ca8d8f74e28be5cb3ee2990193
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Aug 22 19:03:47 2012 +0200
Expose the model in a declarative plugin
commit 318cf0a0d155b432f00408c6ddd24667d9dc59c8
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Aug 22 17:39:22 2012 +0200
add todo
commit 68c7597bd67428cdc0a9471ee44d683bac68f6ec
Author: Aleix Pol <aleixpol at kde.org>
Date: Wed Aug 22 17:38:41 2012 +0200
Create the matches solver that merges duplicates
Also integrate it in the duplicates tool
commit 6085e4f3359b335a0088bda0624a96575f00bb54
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 21 19:45:15 2012 +0200
put all data that has matched
commit 1859789fa79c6bc7c7e330ecc0bd54d419434c22
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 21 19:44:23 2012 +0200
Have the matches sorted by the first row
commit b7bc19563e4d22af9b270ec9ab97435b45b69068
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 21 19:36:20 2012 +0200
Separe the Match class in a different file
commit 656374d544144ca98f6a79fa89fda461a174ab08
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 21 19:35:09 2012 +0200
Make duplicates output more readable
commit 0143942e25630993b9bc33046d86ed99619a17df
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 21 17:57:55 2012 +0200
Report all the roles in the same match together
It will hopefully help to create a better UI for it
commit 3acf0130143f7b7b7841f7e31c2b60acc03f02b1
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 21 16:30:35 2012 +0200
Improve the test by making it possible to properly set the nick
commit 2136cd97747c78c424e32a1e2f01115fb652a32d
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 21 16:30:19 2012 +0200
Improve duplicates output
commit 9135d5325562a90ab77930d9215b978ee3c81093
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 21 16:24:22 2012 +0200
Improve output while reporting duplicates
commit 89da498e5dd26b0cbfdebdb915d3a9a19e47cea4
Author: Aleix Pol <aleixpol at kde.org>
Date: Tue Aug 21 16:23:29 2012 +0200
Report the role we're matching to
commit e30ed0346076fe61c45d2ae3892fa29371642e43
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 21:01:34 2012 +0200
Get lovelypeople to show a bit more info...
Just realized I only get fb contacts... :/
commit 7d6de083ba6019808c6f36a0f0ba020e6c7f0cd7
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 20:42:16 2012 +0200
More work being put on the test
commit 2ee228eb84a5505bed73c6e7ca152be3e0dc7f11
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 20:15:20 2012 +0200
Remove this, it's driving me crazy
If it's really needed, we can add it before releasing...
commit 6cc713da0bb019978375ea37143a364a69419413
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 20:06:57 2012 +0200
Make the test to actually test something
If there's nobody, there are no matches
commit b91fe49c60c2b7865d684bb26a9f245b7becb505
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 20:06:40 2012 +0200
Improve Testability of the library
commit 45214a0738fbc029838bbca42dabec0592f5dc62
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 19:55:16 2012 +0200
Remove the PersonCache singleton
There's not really much point to having it as a singleton. If anything,
PersonModel should be the singleton.
commit e74736fd5d5b0416b436a44a6220e3820de87591
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 19:52:22 2012 +0200
fix the test...
commit e659397bab9a35a2c3c2447268265db0c8df70da
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 19:52:16 2012 +0200
remove warning
writing debug output while destorying a static variable
commit 7a914b4bdaab9ae2a80532d485c30366908aa049
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 19:51:56 2012 +0200
Properly use KJob
commit 0ef20f1e3cedf9c7421d62f2cd23c43668796b7e
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 19:37:46 2012 +0200
Small fixes and extended API for the duplicates
commit 3d9f07ded569694f84dd8b4b7c850d7ce5d57dc7
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 19:37:27 2012 +0200
Add another example that should print all your duplicates
commit 096fb2246451b7e5b0b88abe83384d4317baf4a6
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 19:36:37 2012 +0200
Add some other standard roles for people and contacts
commit 14e592097e611c23f162103c5ffbe202e7f1ef31
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 19:35:15 2012 +0200
Add a unit test for duplicates
commit 82043fbcce4d153bae2b3c54ac699c5b95d72fa9
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 19:34:44 2012 +0200
Rename the examples directory
commit e70615913da0dfcf1a88c2826621733cd7cd4600
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 18:41:40 2012 +0200
First approach to some code that finds duplicate contacts/people
commit 3fef2a5f2330baabc51d8c1c40e2e29061fbaa4a
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 18:11:10 2012 +0200
Try to make sense around hte modification API
although it's not being called
commit 57a1bf5840a60fcee1cc26217457459b948cddde
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 18:08:04 2012 +0200
Not being used...
commit 1ffd3dee56172cc5a8c3fc84c1c4b6a69a9a52c5
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 17:52:50 2012 +0200
If we're not providing this information, just ask the parent class.
commit 3c169a6bef2925508ebb72df3579bef570723ba3
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 17:52:32 2012 +0200
When initializing the cache put the contacts directly to the person
It doesn't really help to do it afterwards in the model and it simplifies
the code a bit.
Also I removed some hashes that were a bit redundant.
commit 75b493f7968d42926878b2c8d0f3c74b3a837869
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 16:37:48 2012 +0200
Simplify the code that initializes the people model
commit 92001e6501cc85cf9e8ac932f4e39522afbe4569
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 16:31:38 2012 +0200
Add myself from blue-system.com to the header
commit 4bababf6ff7a7b5c15cb0f333f7f6c04485373be
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 16:27:39 2012 +0200
Make proper use of the K_GLOBAL_STATIC
And remove some code too
commit 254455b8a17856ec4d6b6d2a671620dfdd254973
Author: Aleix Pol <aleixpol at kde.org>
Date: Mon Aug 20 16:26:44 2012 +0200
improve nepomuk-tp code
--warnings
don't leak d-pointers
commit ce13ae2001b034058280f5a9ce41a7ea05466b95
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 18:32:13 2012 +0200
Remove PersonCacheItem
It wasn't really used outside the newPeople slot where it got changed
to PersonModelItem
commit 82d7d4963fb15775a342a4543e4d58ddceef782b
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 18:31:05 2012 +0200
Adapt to cache changes
commit 477587960c40ef4d797f2d1f996fa27e353ae997
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 18:30:52 2012 +0200
Simplify cache query code
commit fc290c754fa04a1596c25b18aef907f57d460ce6
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 18:30:15 2012 +0200
Don't add values on which we can't trust
commit 5173e1c02b1fa5fcc63d137cdc86a5b1c810e446
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 18:29:50 2012 +0200
Use PersonModelItem
I don't know what PersonCacheItem is
commit abc8c05fb7ae48d1bfcb6388d8d24632b27f8bbc
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 17:59:10 2012 +0200
Reduce complexity by using QVariant API enstead of doing weird things with strings
commit a2450d7d5d4d7d69b01e422e605c6a2a19ce0685
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 17:57:33 2012 +0200
Remove an unneeded d-pointer (nothing inside)
commit efca4b1d9a50d1043559e362e34572548441be0f
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 17:44:19 2012 +0200
Let the contact detect what contact type it is
commit a213652e87471aeb6252cc7fb66285dbf01d6321
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 17:43:51 2012 +0200
Delete d_ptr upon destruction
commit c45bed1e1fd0726e3b301d42c67d61d79edadbc2
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 17:23:29 2012 +0200
Adapt to PersonsModelContactItem
commit 229954c0ae3b071a0ffa691e94129b4042dde129
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 17:23:11 2012 +0200
Use the QStandardDirs infrastructure to provide data
This way we ensure the model signals upon changed data
commit 2615682411182e7539590c5af248fca8d70069a8
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 17:22:21 2012 +0200
remove unused variable and role
commit fa7186b33661553a13a9638d937d97fc982c728c
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 16:52:01 2012 +0200
Nobody is initializing displayName
Don't consider caching it just yet...
commit 8450503f8ef6834b76f18ce07a7bffc96fdf721e
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 16:50:40 2012 +0200
more cleaning up
remove global variables that shouldn't
remove unneeded casts
commit 39438bfe912bfebf0511036639981a339fae9111
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 16:50:01 2012 +0200
Remove useless code
commit ce3dab973984e1a08475b92e054ae3adbea16342
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 16:49:02 2012 +0200
Don't add empty values
They don't mean much... do they?
commit 1d69ef3e7d9125fbe1001e2fc7c4a8e43ec221fa
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 16:48:09 2012 +0200
Remove unused code
commit f9b90f5d797caea288a14debc6ebae38ea9f3da0
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 11:55:31 2012 +0200
Added an example that starts this
commit 33dbee8aee4291b7fe86ce55b4ddf6b8ecda3e6d
Author: Aleix Pol <aleixpol at kde.org>
Date: Fri Aug 17 11:54:06 2012 +0200
Some cleanup
Simplify PersonsModel API by making it a standalone class to be used
whenever it is needed without summoning.
Removed TreeNode in favor of QStandardItem
commit a7cd3385c24a2c9d996c0736c494a951a2821584
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Aug 16 13:01:35 2012 +0200
Add missing files
commit fc4b8000d07102aecea9a68bcc876fc6fb46bd99
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu Aug 9 10:04:29 2012 +0200
Lots of changes I did long time ago, summary follows
Basically this commit removes the facets, moves the query back to the lib and constructs the model bit differently - it puts the nco:contacts in the tree and puts them together only if they both have corresponding pimo:person behind them. Some other improvements.
commit 02bcb9653a18bbf37eeb5c87bd2dcb8e18e54c68
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu May 24 19:32:48 2012 +0200
Compile++ and restore ResourceWatcherService
commit 9ec58614715017dcdb507fb19587c2cfbf7b2686
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu May 24 19:11:42 2012 +0200
Huge cleanup and simplification
The whole architecture just got way easier, it can be boiled down to "Client app asks KPeopleManager to fetch the data, KPM tells PersonCache to perform the query and store the persons and create a tree model out of them, KPM then returns this model, which can be filtered by the type of contact data it contains".
As there are more queries or more persons added to the cache (and the model respectively), they won't show up in the GUI if they don't have the correct contact types (they are filtered out by the proxy filter).
commit 1c09ee3aad4c7598d189c0b09b48d6cc934179e3
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Thu May 24 19:10:30 2012 +0200
Add Persons Model
This is a basic tree model where the first level nodes are persons and their child nodes are their contacts
commit 92940cdc014abd15ac8dd6e3e9cd88bcb40d33b9
Author: Vishesh Handa <handa.vish at gmail.com>
Date: Sat Feb 18 02:36:58 2012 +0530
Added FindKTp.cmake
Copied from kde:ktp-contact-list
commit 13c66dac7b2ae6ed04c94c5a3ca31eba03211b5d
Author: Vishesh Handa <handa.vish at gmail.com>
Date: Sat Feb 18 02:33:20 2012 +0530
Compile the ontologies but do not create the ontology classes
We need telelpathy.h
commit e914997b4cd5156fc32be69349b7897d897ee7eb
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Feb 8 11:14:32 2012 +0100
DigiKam persons stuff
commit d0e70fddc7c9dd1a1a47067a70105e707d029a71
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Feb 8 11:12:39 2012 +0100
Huge changes from rapid and agile development, testing and prototyping
IM is pretty much working now, we still miss metacontacts though. Needs model refactor.
commit e747df187ab101f0594ccb28a7441f1ffe3bfaba
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jan 4 12:54:30 2012 +0100
Very basic and very crappy Telepathy text channel initiator. Proof of concept.
commit cb9171ced8a7b91c73958c24238797748cb2bacb
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jan 4 12:52:34 2012 +0100
Improvements all over the place.
Added common base class for managers.
Improved IMPersonsManager and IMPersonsModel.
Basics for PIMPersonsManager and PIMPersonsModel.
Extended API for IMPersonCacheItemFacet.
commit 97cf0d1c1fdcce033c4a37c6a03a03dbc3831b09
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Jan 4 12:48:04 2012 +0100
Add Telepathy ontology
commit 0883fc4f817de1a78160f5e068ac9b2127f3bf3d
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Dec 7 18:07:29 2011 +0100
Add only required properties from new persons into cache
commit dfc12a814ecd98bca503f22ce47b23ff553421b7
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Wed Dec 7 16:15:18 2011 +0100
Use Nepomuk::Vocabulary keys for data storage and access. Also first ResourceWatcherService draft.
commit d3d61bea241e0df662870d82d1f2a30b230315fd
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date: Tue Dec 6 13:48:48 2011 +0100
First very rough (and very ugly) working version
For now just gets IM data from Nepomuk and stores them in cache. Then it creates an IM model out of the persons with currently only Qt::DisplayRole implemented.
commit 17e5f0645a6798fc34d78f8f290913405a47886e
Author: George Goldberg <george.goldberg at collabora.co.uk>
Date: Sat Sep 17 17:09:28 2011 +0100
Quick hack together of the refcounted shared PersonCacheItemSet class.
commit 3734fc1621e72505e2fea23cd003ca99103b1bb0
Author: George Goldberg <george.goldberg at collabora.co.uk>
Date: Fri Sep 16 16:40:25 2011 +0100
Skeleton build system and classes to start with.
commit b23ff0d960a09e1580723a86122fe331c73a1b5f
Author: George Goldberg <george.goldberg at collabora.co.uk>
Date: Thu Sep 15 17:53:17 2011 +0100
Add basic gitignore file.
-----------------------------------------------------------------------
--
libkpeople packaging
More information about the pkg-kde-commits
mailing list