[SCM] telepathy-qt4 packaging branch, master, updated. debian/0.9.3-1-36-g3f24e4e
Diane Trout
diane-guest at moszumanska.debian.org
Thu Jun 19 17:55:49 UTC 2014
Gitweb-URL: http://git.debian.org/?p=pkg-kde/kde-extras/kde-telepathy/telepathy-qt4.git;a=commitdiff;h=ac11871
The following commit has been merged in the master branch:
commit ac11871d3bcbb1c325d1d195efd387229e0954c7
Author: Diane Trout <diane at ghic.org>
Date: Sat Jun 14 10:45:28 2014 -0700
Remove fix_storing_avatars.patch. Applied upstream.
---
debian/changelog | 1 +
debian/patches/fix_storing_avatars.patch | 55 --------------------------------
debian/patches/series | 1 -
3 files changed, 1 insertion(+), 56 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index f2d4537..eb7797b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,7 @@ telepathy-qt (0.9.4-1) UNRELEASED; urgency=medium
* New upstream release.
* Verify upstream pgp signature.
+ * Remove fix_storing_avatars.patch. Applied upstream.
-- Diane Trout <diane at ghic.org> Sat, 14 Jun 2014 10:17:26 -0700
diff --git a/debian/patches/fix_storing_avatars.patch b/debian/patches/fix_storing_avatars.patch
deleted file mode 100644
index 7afbdf7..0000000
--- a/debian/patches/fix_storing_avatars.patch
+++ /dev/null
@@ -1,55 +0,0 @@
-Author: George Kiagiadakis <george.kiagiadakis at collabora.com>
-Description: Fix storing avatars, so that they are not stored millions of times each
- The original problem lies in the fact that QFile::rename() does not
- overwrite existing files. Therefore it fails and the temporary file
- stays on the filesystem together with the already existing avatar
- file. Checking if the file exists before renaming solves this
- partially, but the problem is that this operation is not atomic. There
- can be many processes using tp-qt, fetching avatars at the same time
- from the server, and in this case we can still have a problem
- there. The final solution is to ignore a new avatar that has the same
- token as an avatar that is already on the filesystem. According to the
- spec, different avatars have different tokens, so if an avatar
- changes, the token changes as well.
-Bug: https://bugs.freedesktop.org/show_bug.cgi?id=47647
-Origin: upstream, http://cgit.freedesktop.org/telepathy/telepathy-qt4/commit/?id=8da9f7069929893bcee64dab22101134752fe618
---- a/TelepathyQt/contact-manager.cpp
-+++ b/TelepathyQt/contact-manager.cpp
-@@ -1341,17 +1341,27 @@
- debug() << "Filename:" << avatarFileName;
- debug() << "MimeType:" << mimeType;
-
-- QTemporaryFile mimeTypeFile(mimeTypeFileName);
-- mimeTypeFile.open();
-- mimeTypeFile.write(mimeType.toLatin1());
-- mimeTypeFile.setAutoRemove(false);
-- mimeTypeFile.rename(mimeTypeFileName);
-+ if (!QFile::exists(mimeTypeFileName)) {
-+ QTemporaryFile mimeTypeFile(mimeTypeFileName);
-+ if (mimeTypeFile.open()) {
-+ mimeTypeFile.write(mimeType.toLatin1());
-+ mimeTypeFile.setAutoRemove(false);
-+ if (!mimeTypeFile.rename(mimeTypeFileName)) {
-+ mimeTypeFile.remove();
-+ }
-+ }
-+ }
-
-- QTemporaryFile avatarFile(avatarFileName);
-- avatarFile.open();
-- avatarFile.write(data);
-- avatarFile.setAutoRemove(false);
-- avatarFile.rename(avatarFileName);
-+ if (!QFile::exists(avatarFileName)) {
-+ QTemporaryFile avatarFile(avatarFileName);
-+ if (avatarFile.open()) {
-+ avatarFile.write(data);
-+ avatarFile.setAutoRemove(false);
-+ if (!avatarFile.rename(avatarFileName)) {
-+ avatarFile.remove();
-+ }
-+ }
-+ }
- }
-
- ContactPtr contact = lookupContactByHandle(handle);
diff --git a/debian/patches/series b/debian/patches/series
index df3bc17..7981047 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,2 @@
-fix_storing_avatars.patch
link-against-gobject.patch
create_moc_command.patch
--
telepathy-qt4 packaging
More information about the pkg-kde-commits
mailing list