[Tahoe-debian] package review

[micah anderson]

On Tue, 26 Apr 2011 00:14:17 +0200, bertagaz at ptitcanardnoir.org wrote:
> Sorry for replying so late, I was offline the last 3 days...

no problem!

> On Sat, Apr 23, 2011 at 01:27:17PM -0400, Micah Anderson wrote:
>
> > I'm not sure what the munin plugin policy is... right now the plugins
> > are being installed in /usr/share/munin/plugins and a config is placed
> > into the munin/plugin-conf.d directory... Is this how it is supposed to
> > work? What happens when munin-node isn't installed on the system?
> 
> Seems that some packages are already installing stuffs in
> /etc/munin/plugin-conf.d/, namely ekeyd or virt-goodies, so I guess it
> isn't as unusual as I believed. Usually this is the place where plugins
> configuration should go, and plugin scripts in /usr/share/munin/plugins,
> so this is what the tahoe package does.

Yeah, it seems fine to me.

> > I noticed there is no man page for tahoe, and I couldn't find one in the
> > upstream source. Has anyone seen any?
> 
> Nop, even google don't think it exists. Is it something that might block
> the package upload? We should consider sending one upload anyway but I was
> hoping it could be delayed for another later upload.

No, it doens't block it. Every binary is supposed to have a man page, we
can easily generate one with help2man and then clean it up, but it
should not block us.

> > Lintian also complained about this:
> > 
> > W: tahoe-lafs source: dh-clean-k-is-deprecated
> > 
> > Info: This package calls dh_clean -k in its <tt>debian/rules</tt> file
> >  and declares a debhelper compatibility version of at least 7.
> >  .
> >  debhelper 7 deprecated dh_clean -k in favour of dh_prep.
> > 
> > The dh_clean -k is in the install target in debian/rules, replacing with
> > dh_prep seems to be fine
> 
> Last time I checked lintian was only complaining about the missing
> manpage, but I might have forgotten to run it against the last package
> version where I did bump the debhelper compatibility.

I ran lintian on sid, don't know if you did as well, or if this was a
new lintian issue that has appeared since your last run.

> > The debian/rules is somewhat old-style, and could probably be converted
> > to the new debhelper methods that make most of the commands listed go
> > away, but that isn't a big deal.
> 
> Yeah, I like how the new debian/rules style looks clean. We should maybe
> consider this for the next upload, when we'll have some feedback from the
> ubuntu maintainer.

agreed.

> > Everything builds find and looks like it installs in a good
> > location. Without the zfec package, I couldn't install the tahoe-lafs
> > package to do some tests with that, but hope that will be soon!
> 
> Yeah, hope so too. Nobody answered to my mail to the debian-python list,
> but I have just been accepted in the python-apps project on alioth, and
> I should now have an access to their svn. I have some work to finish on the
> zfec package and will push it asap. (thought I could dump the few bits of
> knowledge I had of this VCS... :/)

At least it is not CVS...

Let me know about zfec, and I can review/sponsor that too.

micah
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/tahoe-debian/attachments/20110426/f090f069/attachment.pgp>