[Pkg-gnupg-commit] [gpgme] 35/132: tests: Add safeguards against nullptr deref

[Daniel Kahn Gillmor]

This is an automated email from the git hooks/post-receive script.

dkg pushed a commit to branch experimental
in repository gpgme.

commit ca69df8c8d3f044340aee2a118cc20d33cd600a1
Author: Andre Heinecke <aheinecke at intevation.de>
Date:   Tue Jan 17 15:20:56 2017 +0100

    tests: Add safeguards against nullptr deref
    
    * t-gpgconf.c (main): Test some values before dereferencing them.
---
 tests/gpg/t-gpgconf.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/tests/gpg/t-gpgconf.c b/tests/gpg/t-gpgconf.c
index d199d2e..52f0f8b 100644
--- a/tests/gpg/t-gpgconf.c
+++ b/tests/gpg/t-gpgconf.c
@@ -309,9 +309,10 @@ main (void)
     fail_if_err (err);
     if (lookup (conf, "dirmngr", "verbose", &comp, &opt))
       {
-	/* Found.  */
-	test (opt->alt_type == GPGME_CONF_NONE);
-	test ((unsigned long) opt->value->value.count == count);
+        /* Found.  */
+        test (opt->alt_type == GPGME_CONF_NONE);
+        test (opt->value);
+        test ((unsigned long) opt->value->value.count == count);
       }
 
     fprintf (stderr, ".");
@@ -350,9 +351,11 @@ main (void)
     fail_if_err (err);
     if (lookup (conf, "gpg", "keyserver", &comp, &opt))
       {
-	/* Found.  */
-	test (opt->alt_type == GPGME_CONF_STRING);
-	test (strcmp (opt->value->value.string, values[i%2]) == 0);
+        /* Found.  */
+        test (opt->alt_type == GPGME_CONF_STRING);
+        test (opt->value);
+        test (opt->value->value.string);
+        test (strcmp (opt->value->value.string, values[i%2]) == 0);
       }
 
     fprintf (stderr, ".");

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-gnupg/gpgme.git